todo/views/task_assignment.py (1)

241-253: Wrap spoc_id in PyObjectId
Replace the raw request.user_id with PyObjectId(request.user_id) to match AuditLogModel.spoc_id: PyObjectId | None. Ensure you add

from todo.models.common.pyobjectid import PyObjectId

and update:

-    spoc_id=request.user_id,
+    spoc_id=PyObjectId(request.user_id),

todo/views/task.py (3)

79-98: Duplicate profile branch causes dead/unreachable code.

The second if query.validated_data["profile"]: is redundant and never reached.

Apply this diff to remove duplication and keep the richer response formatting:

         if query.validated_data["profile"]:
             status_filter = query.validated_data.get("status", "").upper()
             response = TaskService.get_tasks_for_user(
                 user_id=request.user_id,
                 page=query.validated_data["page"],
                 limit=query.validated_data["limit"],
                 status_filter=status_filter,
             )
-            return Response(data=response.model_dump(mode="json"), status=status.HTTP_200_OK)
-
-        if query.validated_data["profile"]:
-            response = TaskService.get_tasks_for_user(
-                user_id=request.user_id,
-                page=query.validated_data["page"],
-                limit=query.validated_data["limit"],
-            )
-            return Response(
-                data=response.model_dump(mode="json", exclude_none=True),
-                status=status.HTTP_200_OK,
-            )
+            return Response(
+                data=response.model_dump(mode="json", exclude_none=True),
+                status=status.HTTP_200_OK,
+            )

---

100-111: Normalize status in non-profile path for parity.

You uppercased status only in the profile path; apply same normalization here to avoid case-sensitive mismatches.

Apply:

-        status_filter = query.validated_data.get("status")
+        status_filter = (query.validated_data.get("status") or "").upper() or None

---

141-146: Map Pydantic validation errors to 400 instead of 500 when createdBy is invalid.

CreateTaskDTO will raise Pydantic ValidationError (e.g., invalid ObjectId). Current code turns that into a 500.

Apply this diff and import alias:

@@
-        try:
-            dto = CreateTaskDTO(**serializer.validated_data, createdBy=request.user_id)
+        try:
+            dto = CreateTaskDTO(**serializer.validated_data, createdBy=request.user_id)
             response: CreateTaskResponse = TaskService.create_task(dto)
@@
-        except ValueError as e:
+        except PydanticValidationError as e:
+            error_response = ApiErrorResponse(
+                statusCode=400,
+                message=ApiErrors.VALIDATION_ERROR,
+                errors=[{"detail": str(e)}],
+            )
+            return Response(
+                data=error_response.model_dump(mode="json"),
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+        except ValueError as e:
             if isinstance(e.args[0], ApiErrorResponse):
                 error_response = e.args[0]
                 return Response(
                     data=error_response.model_dump(mode="json"),
                     status=error_response.statusCode,
                 )

Add near imports:

+from pydantic import ValidationError as PydanticValidationError