add hotfix to reduce dataset (#1337)

* add hotfix to reduce dataset

* revert changes to yarn lock

* revert end line changes to yarn lock

* clarified conditions to apply unverified role

* fix linting errors

---------

Co-authored-by: Ankush Dharkar <[email protected]>

Author: RitikJaiswal75

controllers/users.js

@@ -324,8 +324,11 @@ const markUnverified = async (req, res) => {
     });
 
     usersInRdsDiscordServer.forEach((discordUser) => {
-      const found = discordUser.roles.find((role) => role === discordDeveloperRoleId);
-      if (found && !rdsUserMap[discordUser.user.id]) {
+      const isDeveloper = discordUser.roles.includes(discordDeveloperRoleId);
+      const isMissingUnverifiedRole = !discordUser.roles.includes(unverifiedRoleId);
+      const isUserUnverified = !rdsUserMap[discordUser.user.id]; // Doesn't have discordId in RDS user object
+
+      if (isDeveloper && isUserUnverified && isMissingUnverifiedRole) {
         usersToApplyUnverifiedRole.push(discordUser.user.id);
       }
     });