fix: eslint issue

surajmaity1 · surajmaity1 · commit 0f84d5e355ef · 2025-05-31T13:20:09.000+05:30
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/eslint.config.js b/eslint.config.js
@@ -32,13 +32,13 @@ export default [
       "no-console": "error",
 
       // Mocha rules
+      "mocha/no-pending-tests": "error",
       "mocha/no-exclusive-tests": "error",
 
       // Prettier for formatting
       "prettier/prettier": "error",
 
-      "no-unused-vars": "off",
+      "no-unused-vars": "warn",
     },
-    ignores: ["public/*", "dist/*"],
   },
 ];
diff --git a/models/items.js b/models/items.js
@@ -70,6 +70,7 @@ const getItemBasedOnFilter = async (query) => {
   try {
     let call = itemTagsModel;
     Object.keys(query).forEach((key) => {
+      // eslint-disable-next-line security/detect-object-injection
       call = call.where(key, "==", query[key]);
     });
     const items = [];
diff --git a/models/logs.js b/models/logs.js
@@ -46,7 +46,9 @@ const fetchLogs = async (query, param) => {
   try {
     let call = logsModel.where("type", "==", param);
     Object.keys(query).forEach((key) => {
+      // eslint-disable-next-line security/detect-object-injection
       if (key !== "limit" && key !== "lastDocId") {
+        // eslint-disable-next-line security/detect-object-injection
         call = call.where(key, "==", query[key]);
       }
     });
diff --git a/models/userStatus.js b/models/userStatus.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 const { Forbidden, NotFound } = require("http-errors");
 const admin = require("firebase-admin");
 const firestore = require("../utils/firestore");
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "morgan": "1.10.0",
     "multer": "1.4.5-lts.1",
     "newrelic": "11.19.0",
-    "nodemailer": "6.7.3",
+    "nodemailer": "7.0.3",
     "nodemailer-mock": "2.0.8",
     "passport": "0.7.0",
     "passport-github2": "0.1.12",
diff --git a/server.js b/server.js
@@ -54,13 +54,13 @@ function onError(error) {
     case "EACCES":
       logger.error(bind + " requires elevated privileges");
       process.exit(1);
-
+      // eslint-disable-next-line no-unreachable
       break;
 
     case "EADDRINUSE":
       logger.error(bind + " is already in use");
       process.exit(1);
-
+      // eslint-disable-next-line no-unreachable
       break;
 
     default:
diff --git a/services/discordService.js b/services/discordService.js
@@ -44,7 +44,7 @@ const setInDiscordFalseScript = async () => {
   const updateUsersPromises = [];
   users.forEach((user) => {
     const id = user.id;
-
+    // eslint-disable-next-line security/detect-object-injection
     delete user[id];
     const userData = {
       ...user,
diff --git a/test/fixtures/discordResponse/discord-response.js b/test/fixtures/discordResponse/discord-response.js
@@ -273,7 +273,7 @@ const getOnboarding31DPlusMembers = [
     nick: "john",
     pending: false,
     premium_since: null,
-
+    // eslint-disable-next-line no-loss-of-precision
     roles: ["9876543210", "11334336"],
     user: {
       id: "9653710123456",
diff --git a/test/integration/contributions.test.js b/test/integration/contributions.test.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 const chai = require("chai");
 const sinon = require("sinon");
 const { expect } = chai;
diff --git a/test/integration/discordactions.test.js b/test/integration/discordactions.test.js
@@ -218,7 +218,7 @@ describe("Discord actions", function () {
 
   describe("DELETE /discord-actions/groups/:groupId", function () {
     let groupId;
-
+    // eslint-disable-next-line mocha/no-setup-in-describe
     const roleData = groupData[0];
 
     beforeEach(async function () {
@@ -952,6 +952,7 @@ describe("Discord actions", function () {
     });
   });
 
+  // eslint-disable-next-line mocha/no-pending-tests
   describe.skip("GET /discord-actions/invite", function () {
     it("should return the invite for the user if no userId is provided in the params and the invite exists", async function () {
       await addInviteToInviteModel({ userId: superUserId, inviteLink: "discord.gg/apQYT7HB" });
@@ -994,6 +995,7 @@ describe("Discord actions", function () {
   });
 
   // <------ Will revisit this later https://github.com/Real-Dev-Squad/website-backend/issues/2078 --->
+  // eslint-disable-next-line mocha/no-pending-tests
   describe.skip("POST /discord-actions/invite", function () {
     afterEach(function () {
       sinon.restore();
@@ -1009,6 +1011,7 @@ describe("Discord actions", function () {
       expect(res.body.message).to.be.equal("User should be super user to generate link for other users");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should return 403 if the user has discord id in their user object, which means user is already in discord", async function () {
       const res = await chai
         .request(app)
@@ -1019,6 +1022,7 @@ describe("Discord actions", function () {
       expect(res.body.message).to.be.equal("Only users who have never joined discord can generate invite link");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should return 403 if user has role archieved", async function () {
       archievedUserId = await addUser(archievedUser);
       archievedUserToken = authService.generateAuthToken({ userId: archievedUserId });
@@ -1031,6 +1035,7 @@ describe("Discord actions", function () {
       expect(res.body.message).to.be.equal("Archived users cannot generate invite");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should return 403 if the user doesn't have role designer, product_manager, or mavens", async function () {
       developerUserWithoutApprovedProfileStatusId = await addUser(developerUserWithoutApprovedProfileStatus);
       developerUserWithoutApprovedProfileStatusToken = authService.generateAuthToken({
@@ -1045,6 +1050,7 @@ describe("Discord actions", function () {
       expect(res.body.message).to.be.equal("Only selected roles can generate discord link directly");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should generate discord link if user is a product mananger", async function () {
       fetchStub.returns(
         Promise.resolve({
@@ -1065,6 +1071,7 @@ describe("Discord actions", function () {
       expect(res.body.inviteLink).to.be.equal("discord.gg/xyz");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should generate discord link if user is a designer", async function () {
       fetchStub.returns(
         Promise.resolve({
@@ -1085,6 +1092,7 @@ describe("Discord actions", function () {
       expect(res.body.inviteLink).to.be.equal("discord.gg/zlmfasd");
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should generate discord link if user is a maven", async function () {
       fetchStub.returns(
         Promise.resolve({
@@ -1145,6 +1153,7 @@ describe("Discord actions", function () {
       );
     });
 
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should generate discord link if user has an approved application", async function () {
       sinon.stub(ApplicationModel, "getUserApplications").resolves([{ status: "accepted" }]);
       fetchStub.returns(
@@ -1309,7 +1318,7 @@ describe("Discord actions", function () {
           expect(res.body.message).to.equal("Roles fetched successfully!");
           expect(res.body.groups).to.be.an("array");
           expect(res.body.links).to.have.keys(["next", "prev"]);
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.links.next).to.be.null;
           expect(res.body.links.prev).to.equal(`/discord-actions/groups?page=${page - 1}&size=${size}&dev=true`);
           return done();
@@ -1341,10 +1350,10 @@ describe("Discord actions", function () {
           expect(res).to.have.status(200);
           expect(res.body).to.be.an("object");
           expect(res.body.message).to.equal("Roles fetched successfully!");
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.groups).to.be.an("array").that.is.empty;
           expect(res.body.links).to.have.keys(["next", "prev"]);
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.links.next).to.be.null;
           expect(res.body.links.prev).to.equal(`/discord-actions/groups?page=${page - 1}&size=${size}&dev=true`);
           return done();
diff --git a/test/integration/members.test.js b/test/integration/members.test.js
@@ -210,7 +210,7 @@ describe("Members", function () {
             }
 
             expect(res).to.have.status(204);
-
+            /* eslint-disable no-unused-expressions */
             expect(res.body).to.be.a("object").to.be.empty;
 
             return done();
@@ -325,7 +325,7 @@ describe("Members", function () {
             }
 
             expect(res).to.have.status(204);
-
+            /* eslint-disable no-unused-expressions */
             expect(res.body).to.be.a("object").to.be.empty;
 
             return done();
diff --git a/test/integration/notify.test.js b/test/integration/notify.test.js
@@ -23,6 +23,7 @@ describe("Notify Test", function () {
   });
 
   describe("POST call to notify", function () {
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("should send message to specified users", async function () {
       // skipping the test because it connects with firebase cloud messaging service which we are unable to mock.
 
diff --git a/test/integration/progressesTasks.test.js b/test/integration/progressesTasks.test.js
@@ -674,10 +674,10 @@ describe("Test Progress Updates API for Tasks", function () {
           expect(res).to.have.status(200);
           expect(res.body).to.be.an("object");
           expect(res.body.message).to.equal("Progress document retrieved successfully.");
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.data).to.be.an("array").that.is.empty;
           expect(res.body.links).to.have.keys(["next", "prev"]);
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.links.next).to.be.null;
           expect(res.body.links.prev).to.equal(`/progresses?type=task&page=${page - 1}&size=${size}&dev=true`);
           return done();
diff --git a/test/integration/progressesUsers.test.js b/test/integration/progressesUsers.test.js
@@ -511,10 +511,10 @@ describe("Test Progress Updates API for Users", function () {
           expect(res).to.have.status(200);
           expect(res.body).to.be.an("object");
           expect(res.body.message).to.equal("Progress document retrieved successfully.");
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.data).to.be.an("array").that.is.empty;
           expect(res.body.links).to.have.keys(["next", "prev"]);
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.links.next).to.be.null;
           expect(res.body.links.prev).to.equal(`/progresses?type=user&page=${page - 1}&size=${size}&dev=true`);
           return done();
diff --git a/test/integration/userStatus.test.js b/test/integration/userStatus.test.js
@@ -348,6 +348,7 @@ describe("UserStatus", function () {
     });
 
     // Skipping this as the users are not allowed to mark them as active or idle. Will remove the test while removing the feature flag.
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("Should update the User Status", function (done) {
       chai
         .request(app)
@@ -381,6 +382,7 @@ describe("UserStatus", function () {
     });
 
     // Skipping this as the users are not allowed to mark them as active or idle. Will remove the test while removing the feature flag.
+    // eslint-disable-next-line mocha/no-pending-tests
     it.skip("Should update the User Status when requested by Super User", function (done) {
       chai
         .request(app)
diff --git a/test/integration/usersFilter.test.js b/test/integration/usersFilter.test.js
@@ -198,7 +198,7 @@ describe("Filter Users", function () {
             expect(res.body.links).to.have.property("prev");
           } else {
             expect(res.body.message).to.equal("No users found");
-
+            // eslint-disable-next-line no-unused-expressions
             expect(res.body.users).to.be.a("array").that.is.empty;
           }
 
@@ -274,7 +274,7 @@ describe("Filter Users", function () {
           expect(res).to.have.status(200);
           expect(res.body).to.be.an("object");
           expect(res.body.message).to.equal("No users found");
-
+          // eslint-disable-next-line no-unused-expressions
           expect(res.body.users).to.be.an("array").that.is.empty;
           expect(res.body.links).to.have.property("next");
           expect(res.body.links).to.have.property("prev");
diff --git a/test/unit/models/discordactions.test.js b/test/unit/models/discordactions.test.js
@@ -843,7 +843,7 @@ describe("discordactions", function () {
     it("should add invite in the invite model for user", async function () {
       const inviteObject = { userId: "kfjkasdfl", inviteLink: "discord.gg/xyz" };
       const inviteId = await addInviteToInviteModel(inviteObject);
-      expect(inviteId).to.exist;
+      expect(inviteId).to.exist; // eslint-disable-line no-unused-expressions
     });
   });
 
diff --git a/test/unit/models/events.test.js b/test/unit/models/events.test.js
@@ -166,6 +166,7 @@ describe("Events", function () {
     it("should get event codes", async function () {
       await eventQuery.createEvent(eventDataArray[1]);
 
+      // eslint-disable-next-line no-unused-vars
       const allEventCodesPromises = eventCodeDataArray[1].data.map(async (code) => {
         const eventCodeRef = await eventQuery.createEventCode(code);
         const eventCodeSnapshot = await eventCodeRef.get();
diff --git a/test/unit/models/logs.test.js b/test/unit/models/logs.test.js
@@ -150,7 +150,7 @@ describe("Logs", function () {
       expect(result.allLogs).to.have.lengthOf(3);
       expect(result).to.have.any.key("prev");
       expect(result).to.have.any.key("next");
-
+      // eslint-disable-next-line no-unused-expressions
       expect(result.next).to.not.be.null;
     });
 
@@ -171,12 +171,12 @@ describe("Logs", function () {
       expect(nextData.allLogs).to.have.lengthOf(4);
       expect(nextData).to.have.any.key("prev");
       expect(nextData).to.have.any.key("next");
-
+      // eslint-disable-next-line no-unused-expressions
       expect(nextData.prev).to.not.be.null;
       const prevData = await logsQuery.fetchAllLogs({ prev: nextData.prev });
       expect(prevData).to.have.any.key("prev");
       expect(prevData).to.have.any.key("next");
-
+      // eslint-disable-next-line no-unused-expressions
       expect(prevData.next).to.exist;
     });
 
diff --git a/test/unit/models/recruiters.test.js b/test/unit/models/recruiters.test.js
@@ -2,7 +2,7 @@
  * This eslint rule is disabled because of https://github.com/nodesecurity/eslint-plugin-security/issues/21
  * It gives linting errors in testing the DB data with keys from fixtures
  */
-
+/* eslint-disable security/detect-object-injection */
 const chai = require("chai");
 const { expect } = chai;
 
diff --git a/test/unit/models/tasks.test.js b/test/unit/models/tasks.test.js
@@ -2,6 +2,7 @@
  * This eslint rule is disabled because of https://github.com/nodesecurity/eslint-plugin-security/issues/21
  * It gives linting errors in testing the DB data with keys from fixtures
  */
+/* eslint-disable security/detect-object-injection */
 
 const chai = require("chai");
 const sinon = require("sinon");
diff --git a/test/unit/models/users.test.js b/test/unit/models/users.test.js
@@ -2,6 +2,7 @@
  * This eslint rule is disabled because of https://github.com/nodesecurity/eslint-plugin-security/issues/21
  * It gives linting errors in testing the DB data with keys from fixtures
  */
+/* eslint-disable security/detect-object-injection */
 
 const chai = require("chai");
 const sinon = require("sinon");
diff --git a/test/unit/utils/progresses.test.js b/test/unit/utils/progresses.test.js
@@ -139,6 +139,7 @@ describe("Utils | Progresses", function () {
       const query = progressesCollection.where("userId", "==", "nonExistentUser");
       const results = await getPaginatedProgressDocs(query, 1);
 
+      // eslint-disable-next-line no-unused-expressions
       expect(results).to.be.an("array").that.is.empty;
     });
 
diff --git a/utils/helper.js b/utils/helper.js
@@ -16,7 +16,7 @@ const getQualifiers = (query) => {
 
   combinations.forEach((combination) => {
     const [qualifier, value] = combination.split(":");
-
+    // eslint-disable-next-line security/detect-object-injection
     qualifiers[qualifier] = value;
   });
 
diff --git a/utils/logs.js b/utils/logs.js
diff --git a/utils/users.js b/utils/users.js
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable no-console */`
`1`	`2`	`const { Forbidden, NotFound } = require("http-errors");`
`2`	`3`	`const admin = require("firebase-admin");`
`3`	`4`	`const firestore = require("../utils/firestore");`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable no-unused-expressions */`
`1`	`2`	`const chai = require("chai");`
`2`	`3`	`const sinon = require("sinon");`
`3`	`4`	`const { expect } = chai;`