chore: remove unused code

Author: bhtibrewal

constants/roles.js

@@ -4,7 +4,7 @@ const ROLES = {
   APPOWNER: "app_owner",
   MEMBER: "member",
   ARCHIVED: "archived",
-  IN_DISCORD: "inDiscord",
+  INDISCORD: "in_discord",
 };
 
 module.exports = ROLES;

controllers/users.js

@@ -8,12 +8,10 @@ const { logType } = require("../constants/logs");
 
 const logger = require("../utils/logger");
 const obfuscate = require("../utils/obfuscate");
-const { getPaginationLink, getUsernamesFromPRs, mapDiscordMembersDataAndSyncRole } = require("../utils/users");
+const { getPaginationLink, getUsernamesFromPRs } = require("../utils/users");
 const { getQualifiers } = require("../utils/helper");
 const { SOMETHING_WENT_WRONG, INTERNAL_SERVER_ERROR } = require("../constants/errorMessages");
 const { getFilteredPRsOrIssues } = require("../utils/pullRequests");
-const { IN_DISCORD } = require("../constants/roles");
-const jwt = require("jsonwebtoken");
 
 const verifyUser = async (req, res) => {
   const userId = req.userData.id;
@@ -467,55 +465,6 @@ const filterUsers = async (req, res) => {
     return res.boom.serverUnavailable("Something went wrong please contact admin");
   }
 };
-const DISCORD_BASE_URL = "https://89d4-49-36-233-201.ngrok.io";
-const syncInDiscordRole = async (req, res) => {
-  try {
-    const authToken = jwt.sign({}, config.get("botToken.botPrivateKey"), {
-      algorithm: "RS256",
-    });
-
-    const response = await fetch(`${DISCORD_BASE_URL}/discord-members`, {
-      headers: {
-        "Content-Type": "application/json",
-        Authorization: `Bearer ${authToken}`,
-      },
-    });
-    const discordMembers = await response.json();
-
-    const allUsers = await userQuery.getAllUsers();
-    mapDiscordMembersDataAndSyncRole(allUsers, discordMembers);
-
-    return res.json({ message: "Synced with discord members " });
-  } catch (error) {
-    logger.error(`Error while fetching all users: ${error}`);
-    return res.boom.serverUnavailable("Something went wrong please contact admin");
-  }
-};
-
-const fetchVerifiedUsers = async (req, res) => {
-  try {
-    const verifiedUsers = await userQuery.fetchUsersWhereFieldNotNull("discordId");
-    return res.json(verifiedUsers);
-  } catch (error) {
-    logger.error(`Error while fetching all users: ${error}`);
-    return res.boom.serverUnavailable("Something went wrong please contact admin");
-  }
-};
-
-const fetchInDiscordUsers = async (req, res) => {
-  try {
-    const usersInDiscord = await userQuery.fetchUsersWithRole(IN_DISCORD);
-
-    return res.json({
-      message: "Users found successfully!",
-      users: usersInDiscord,
-      count: usersInDiscord.length,
-    });
-  } catch (error) {
-    logger.error(`Error while fetching all users: ${error}`);
-    return res.boom.serverUnavailable("Something went wrong please contact admin");
-  }
-};
 
 module.exports = {
   verifyUser,
@@ -536,7 +485,4 @@ module.exports = {
   addDefaultArchivedRole,
   getUserSkills,
   filterUsers,
-  fetchInDiscordUsers,
-  syncInDiscordRole,
-  fetchVerifiedUsers,
 };

models/users.js

@@ -414,22 +414,6 @@ const getUsersBasedOnFilter = async (query) => {
     const filteredUserDocs = userDocs.filter((doc) => !doc.roles?.archived);
     return filteredUserDocs;
   }
-  return [];
-};
-const getAllUsers = async () => {
-  try {
-    const usersRef = await userModel.get();
-    return usersRef;
-  } catch (err) {
-    logger.error("Error retrieving users data with roles of inDiscord", err);
-    throw err;
-  }
-};
-const fetchUsersWithRole = async (role) => {
-  try {
-    // console.log(role);
-    const snapshot = await userModel.where(`roles.${role}`, "==", true).get();
-    const onlyMembers = [];
 
   const roleQuery = query.role;
   const verifiedQuery = query.verified;
@@ -447,7 +431,6 @@ const fetchUsersWithRole = async (role) => {
     return filteredUsers;
   }
   if (verifiedQuery) {
-    console.log(typeof verifiedQuery);
     const filteredUsers = [];
     const snapshot = await userModel.orderBy("discordId").get();
     snapshot.forEach((doc) => {
@@ -477,7 +460,4 @@ module.exports = {
   getRdsUserInfoByGitHubUsername,
   fetchUsers,
   getUsersBasedOnFilter,
-  fetchUsersWithRole,
-  fetchUsersWhereFieldNotNull,
-  getAllUsers,
 };

routes/users.js

@@ -16,9 +16,6 @@ router.get("/self", authenticate, users.getSelfDetails);
 router.get("/isUsernameAvailable/:username", authenticate, users.getUsernameAvailabilty);
 router.get("/chaincode", authenticate, users.generateChaincode);
 router.get("/search", userValidator.validateUserQueryParams, users.filterUsers);
-router.get("/inDiscord", authenticate, users.fetchInDiscordUsers);
-router.post("/syncInDiscord", authenticate, users.syncInDiscordRole);
-router.get("/verified", authenticate, users.fetchVerifiedUsers);
 router.get("/:username", users.getUser);
 router.get("/:userId/intro", authenticate, authorizeRoles([SUPERUSER]), users.getUserIntro);
 router.put("/self/intro", authenticate, userValidator.validateJoinData, users.addUserIntro);

test/unit/utils/users.test.js

@@ -1,8 +1,6 @@
 const chai = require("chai");
 const { expect } = chai;
 
-const sinon = require("sinon");
-
 const usersUtils = require("../../../utils/users");
 const cleanDb = require("../../utils/cleanDb");
 const addUser = require("../../utils/addUser");
@@ -67,60 +65,4 @@ describe("users", function () {
       expect(participantUserId).to.include(userId);
     });
   });
-
-  describe("mapDiscordMembersDataAndSyncRole", function () {
-    it("should update roles and joined_discord fields for users with matching Discord IDs", function () {
-      const allUsers = [
-        {
-          data: () => ({ roles: { archived: false }, discordId: "123" }),
-          ref: { update: sinon.spy() },
-        },
-      ];
-      const discordMembers = [
-        {
-          user: { id: "123" },
-          joined_at: "2022-05-01T00:00:00.000Z",
-        },
-      ];
-
-      usersUtils.mapDiscordMembersDataAndSyncRole(allUsers, discordMembers);
-
-      sinon.assert.calledWithExactly(allUsers[0].ref.update, {
-        roles: { archived: false, inDiscord: true },
-        joined_discord: discordMembers[0].joined_at,
-      });
-    });
-
-    it("should update roles field to inDiscord: false for users with no matching Discord ID", function () {
-      const allUsers = [
-        {
-          data: () => ({ roles: { archived: false }, discordId: "123" }),
-          ref: { update: sinon.spy() },
-        },
-      ];
-      const discordMembers = [];
-
-      usersUtils.mapDiscordMembersDataAndSyncRole(allUsers, discordMembers);
-
-      sinon.assert.calledWithExactly(allUsers[0].ref.update, {
-        roles: { archived: false, inDiscord: false },
-      });
-    });
-
-    it("should update roles field to inDiscord: false for users with archived roles", function () {
-      const allUsers = [
-        {
-          data: () => ({ roles: { archived: true }, discordId: "123" }),
-          ref: { update: () => sinon.spy() },
-        },
-      ];
-      const discordMembers = [];
-
-      usersUtils.mapDiscordMembersDataAndSyncRole(allUsers, discordMembers);
-
-      expect(allUsers[0].ref.update).to.have.been.calledWith({
-        roles: { archived: true, inDiscord: false },
-      });
-    });
-  });
 });