changes after randhir review

Author: shubhamsinghbundela

test/fixtures/userStatus/userStatus.js

@@ -13,12 +13,12 @@ const userStatusDataForNewUser = {
 };
 
 const userStatusDataAfterSignup = {
-  currentStatus: { state: "ONBOARDING", until: "" },
+  currentStatus: { state: "ONBOARDING" },
   monthlyHours: { committed: 0 },
 };
 
-const userStatusDataAfterFillJoin = {
-  currentStatus: { state: "ONBOARDING", until: "" },
+const userStatusDataAfterFillingJoinSection = {
+  currentStatus: { state: "ONBOARDING" },
   monthlyHours: { committed: 40 },
 };
 
@@ -64,7 +64,7 @@ const generateUserStatusData = (state, updatedAt, from, until = "", message = ""
 module.exports = {
   userStatusDataForNewUser,
   userStatusDataAfterSignup,
-  userStatusDataAfterFillJoin,
+  userStatusDataAfterFillingJoinSection,
   userStatusDataForOooState,
   oooStatusDataForShortDuration,
   generateUserStatusData,

test/integration/users.test.js

@@ -16,7 +16,10 @@ const searchParamValues = require("../fixtures/user/search")();
 
 const config = require("config");
 const joinData = require("../fixtures/user/join");
-const { userStatusDataAfterSignup, userStatusDataAfterFillJoin } = require("../fixtures/userStatus/userStatus");
+const {
+  userStatusDataAfterSignup,
+  userStatusDataAfterFillingJoinSection,
+} = require("../fixtures/userStatus/userStatus");
 const { addJoinData, addOrUpdate } = require("../../models/users");
 const userStatusModel = require("../../models/userStatus");
 
@@ -695,7 +698,7 @@ describe("Users", function () {
     let userStatusData;
     beforeEach(async function () {
       await userStatusModel.updateUserStatus(userId, userStatusDataAfterSignup);
-      const updateStatus = await userStatusModel.updateUserStatus(userId, userStatusDataAfterFillJoin);
+      const updateStatus = await userStatusModel.updateUserStatus(userId, userStatusDataAfterFillingJoinSection);
       userStatusData = (await firestore.collection("usersStatus").doc(updateStatus.id).get()).data();
     });
     it("should return 409 if the data already present", function (done) {