reafctor: fixed assert statement

Author: pankajjs

middlewares/authorizeBot.js

@@ -19,7 +19,7 @@ const verifyCronJob = async (req, res, next) => {
 const verifyDiscordBot = async (req, res, next) => {
   try {
     const token = req.headers.authorization.split(" ")[1];
-    const serviceName = req.headers[HEADERS.SERVICE_NAME] || "";
+    const serviceName = req.headers[HEADERS.SERVICE_NAME] ?? "";
 
     if (serviceName === DISCORD_SERVICE) {
       const data = botVerifcation.verifyDiscordService(token);
@@ -28,6 +28,7 @@ const verifyDiscordBot = async (req, res, next) => {
       }
       return next();
     }
+
     const data = botVerifcation.verifyToken(token);
     if (data.name !== CLOUDFLARE_WORKER) {
       return res.boom.unauthorized("Unauthorized Bot");

test/unit/middlewares/authorizeBot.test.js

@@ -150,8 +150,7 @@ describe("Middleware | Authorize Bot", function () {
       authorizeBot.verifyDiscordBot(request, response, nextSpy);
 
       expect(nextSpy.calledOnce).to.be.equal(false);
-      expect(boomUnauthorizedSpy.calledOnce).to.be.equal(true);
-
+      expect(response.boom.unauthorized.calledOnce).to.be.equal(true);
       jwtStub.restore();
     });
 
@@ -171,7 +170,7 @@ describe("Middleware | Authorize Bot", function () {
 
       authorizeBot.verifyDiscordBot(request, response, nextSpy);
       expect(nextSpy.calledOnce).to.be.equal(false);
-      expect(boomBadRequestSpy.calledOnce).to.be.equal(true);
+      expect(response.boom.badRequest.calledOnce).to.be.equal(true);
     });
 
     it("should allow request propagation when token is valid for discord service", function () {
@@ -217,7 +216,7 @@ describe("Middleware | Authorize Bot", function () {
 
       authorizeBot.verifyDiscordBot(request, response, nextSpy);
       expect(nextSpy.calledOnce).to.be.equal(false);
-      expect(boomUnauthorizedSpy.calledOnce).to.be.equal(true);
+      expect(response.boom.unauthorized.calledOnce).to.be.equal(true);
     });
 
     it("should return unauthorized when token is valid but not for cloudflare worker", function () {
@@ -230,7 +229,7 @@ describe("Middleware | Authorize Bot", function () {
 
       const response = {
         boom: {
-          unauthorized: sinon.spy(),
+          unauthorized: boomUnauthorizedSpy,
         },
       };
       authorizeBot.verifyDiscordBot(request, response, nextSpy);