Refactor the isMember check

sumitd94 · sumitd94 · commit 51b90a5502d8 · 2021-06-11T09:12:24.000+05:30
diff --git a/models/members.js b/models/members.js
@@ -27,11 +27,7 @@ const fetchMembers = async () => {
           phone: undefined,
           email: undefined
         }
-        if (memberData.roles && memberData.roles.member) {
-          allMembers.isMember = true
-        } else {
-          allMembers.isMember = false
-        }
+        curatedMemberData.isMember = !!(memberData.roles && memberData.roles.member)
         allMembers.push(curatedMemberData)
       })
     }

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,7 @@ const fetchMembers = async () => {`
`27`	`27`	`phone: undefined,`
`28`	`28`	`email: undefined`
`29`	`29`	`}`
`30`		`- if (memberData.roles && memberData.roles.member) {`
`31`		`- allMembers.isMember = true`
`32`		`- } else {`
`33`		`- allMembers.isMember = false`
`34`		`- }`
	`30`	`+ curatedMemberData.isMember = !!(memberData.roles && memberData.roles.member)`
`35`	`31`	`allMembers.push(curatedMemberData)`
`36`	`32`	`})`
`37`	`33`	`}`