Skip to content

Commit 588a387

Browse files
Merge pull request #1122 from Real-Dev-Squad/task-dependency-v3
changed dependsId to dependsOn Merged on: 31 May 2023 11:30 AM IST
2 parents 21fd72b + 4f10d7d commit 588a387

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

models/tasks.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ const addDependency = async (data) => {
4747
if (dependsOn.length > 500) {
4848
throw new Error("Error cannot add more than 500 taskId");
4949
}
50-
for (const dependsId of dependsOn) {
50+
for (const dependency of dependsOn) {
5151
const taskDependOn = {
52-
taskId,
53-
dependsId,
52+
taskId: taskId,
53+
dependsOn: dependency,
5454
};
5555
const docid = dependencyModel.doc();
5656
batch.set(docid, taskDependOn);
@@ -80,8 +80,8 @@ const fetchTasks = async () => {
8080
const dependencySnapshot = await dependencyModel.where("taskId", "==", taskId).get();
8181
task.dependsOn = [];
8282
dependencySnapshot.docs.forEach((doc) => {
83-
const dependsId = doc.get("dependsId");
84-
task.dependsOn.push(dependsId);
83+
const dependency = doc.get("dependsOn");
84+
task.dependsOn.push(dependency);
8585
});
8686
return task;
8787
});
@@ -126,8 +126,8 @@ const fetchTask = async (taskId) => {
126126
const task = await tasksModel.doc(taskId).get();
127127
const dependencySnapshot = await dependencyModel.where("taskId", "==", taskId).get();
128128
const dependencyDocReference = dependencySnapshot.docs.map((doc) => {
129-
const dependsId = doc.get("dependsId");
130-
return dependsId;
129+
const dependency = doc.get("dependsOn");
130+
return dependency;
131131
});
132132
const taskData = await fromFirestoreData(task.data());
133133
if (taskData?.status) {

0 commit comments

Comments
 (0)