fix: coderabbit suggested changes

Author: lakshayman

controllers/users.js

@@ -137,15 +137,16 @@ const getUsers = async (req, res) => {
     }
 
     if (profileStatus) {
+      const normalizedProfileStatus = String(profileStatus).trim().toUpperCase();
       try {
-        const users = await userQuery.fetchUserForKeyValue("profileStatus", profileStatus);
+        const users = await userQuery.fetchUserForKeyValue("profileStatus", normalizedProfileStatus);
         return res.json({
-          message: `Users with profile status ${profileStatus} returned successfully!`,
+          message: `Users with profile status ${normalizedProfileStatus} returned successfully!`,
           count: users.length,
           users: users,
         });
       } catch (error) {
-        logger.error(`Error while fetching users with profile status ${profileStatus}: ${error}`);
+        logger.error(`Error while fetching users with profile status ${normalizedProfileStatus}: ${error}`);
         return res.boom.serverUnavailable(SOMETHING_WENT_WRONG);
       }
     }

middlewares/validators/user.js

@@ -197,7 +197,7 @@ async function getUsers(req, res, next) {
       query: joi.string().optional(),
       q: joi.string().optional(),
       profile: joi.string().valid("true").optional(),
-      profileStatus: joi.string().optional().messages({
+      profileStatus: joi.string().trim().uppercase().optional().messages({
         "string.empty": "profileStatus value must not be empty",
       }),
       filterBy: joi.string().optional(),

test/integration/users.test.js

@@ -1015,6 +1015,24 @@ describe("Users", function () {
           return done();
         });
     });
+
+    it("Should accept lowercase profileStatus", function (done) {
+            chai
+              .request(app)
+        .get("/users?profileStatus=blocked")
+        .end((err, res) => {
+          if (err) {
+            return done(err);
+          }
+          expect(res).to.have.status(200);
+          expect(res.body).to.be.a("object");
+          expect(res.body.users).to.be.a("array");
+          res.body.users.forEach((user) => {
+            expect(user.profileStatus).to.equal("BLOCKED");
+          });
+          return done();
+        });
+      });
   });
 
   describe("GET /users/self", function () {

test/unit/middlewares/user-validator.test.js

@@ -502,6 +502,24 @@ describe("Middleware | Validators | User", function () {
       expect(next.calledOnce).to.be.equal(true);
     });
 
+    it("Stops the propagation when profileStatus is empty", async function () {
+      const req = {
+        query: {
+          profileStatus: "",
+        },
+      };
+      const res = {
+        boom: {
+          badRequest: () => {},
+        },
+      };
+      const nextSpy = sinon.spy();
+      await getUsers(req, res, nextSpy).catch((err) => {
+        expect(err).to.be.an.instanceOf(Error);
+      });
+      expect(nextSpy.calledOnce).to.be.equal(false);
+    });
+
     it("Stops the request for passing on to next", async function () {
       const req = {
         query: {