fix: eslint issue

Author: surajmaity1

controllers/tasks.js

@@ -375,7 +375,8 @@ const updateTaskStatus = async (req, res, next) => {
         const isCurrProgress100 = parseInt(task.taskData.percentCompleted || 0) === 100;
         const isCurrProgress0 = parseInt(task.taskData.percentCompleted || 0) === 0;
         const isNewProgress100 = !!req.body.percentCompleted && parseInt(req.body.percentCompleted) === 100;
-        const isNewProgress0 = !!req.body.percentCompleted !== undefined && parseInt(req.body.percentCompleted) === 0;
+        const percentCompleted = req.body.percentCompleted;
+        const isNewProgress0 = percentCompleted !== undefined && parseInt(percentCompleted) === 0;
 
         if (
           !isCurrProgress100 &&

eslint.config.js

@@ -1,46 +1,44 @@
-const { defineConfig } = require("eslint/config");
-const globals = require("globals");
-const mocha = require("eslint-plugin-mocha");
-const security = require("eslint-plugin-security");
-const prettier = require("eslint-plugin-prettier");
+import js from "@eslint/js";
+import globals from "globals";
+import mochaPlugin from "eslint-plugin-mocha";
+import securityPlugin from "eslint-plugin-security";
+import prettierPlugin from "eslint-plugin-prettier";
 
-module.exports = defineConfig([
+export default [
   {
     ignores: ["dist/*", "**/.eslintrc.js", "public/*"],
   },
+  js.configs.recommended,
   {
     languageOptions: {
+      ecmaVersion: "latest",
+      sourceType: "module",
       globals: {
-        ...globals.commonjs,
         ...globals.node,
         ...globals.mocha,
-        ...globals.es2021,
         config: "readonly",
         logger: "readonly",
       },
-
-      ecmaVersion: 13,
-      parserOptions: {},
     },
-
     plugins: {
-      mocha,
-      security,
-      prettier,
+      mocha: mochaPlugin,
+      security: securityPlugin,
+      prettier: prettierPlugin,
     },
-
     rules: {
       // Custom eslint rules
       "no-trailing-spaces": "error",
       "consistent-return": "error",
       "no-console": "error",
 
-      // Custom mocha rules
-      "mocha/no-skipped-tests": "error",
+      // Mocha rules
       "mocha/no-exclusive-tests": "error",
 
       // Prettier for formatting
       "prettier/prettier": "error",
+
+      "no-unused-vars": "off",
     },
+    ignores: ["public/*", "dist/*"],
   },
-]);
+];

models/events.js

@@ -214,7 +214,7 @@ const createEventCode = async (eventCodeData) => {
     const data = docSnapshot.data();
 
     const previouslyPresentEventCodes = eventSnapshotData?.event_codes?.by_role?.mavens && [
-      ...eventSnapshotData?.event_codes?.by_role?.mavens,
+      ...eventSnapshotData.event_codes.by_role.mavens,
     ];
 
     if (!data) throw new Error();

models/items.js

@@ -70,7 +70,6 @@ const getItemBasedOnFilter = async (query) => {
   try {
     let call = itemTagsModel;
     Object.keys(query).forEach((key) => {
-      // eslint-disable-next-line security/detect-object-injection
       call = call.where(key, "==", query[key]);
     });
     const items = [];

models/logs.js

@@ -46,9 +46,7 @@ const fetchLogs = async (query, param) => {
   try {
     let call = logsModel.where("type", "==", param);
     Object.keys(query).forEach((key) => {
-      // eslint-disable-next-line security/detect-object-injection
       if (key !== "limit" && key !== "lastDocId") {
-        // eslint-disable-next-line security/detect-object-injection
         call = call.where(key, "==", query[key]);
       }
     });

models/userStatus.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 const { Forbidden, NotFound } = require("http-errors");
 const admin = require("firebase-admin");
 const firestore = require("../utils/firestore");

server.js

@@ -54,13 +54,13 @@ function onError(error) {
     case "EACCES":
       logger.error(bind + " requires elevated privileges");
       process.exit(1);
-      // eslint-disable-next-line no-unreachable
+
       break;
 
     case "EADDRINUSE":
       logger.error(bind + " is already in use");
       process.exit(1);
-      // eslint-disable-next-line no-unreachable
+
       break;
 
     default:

services/discordService.js

@@ -44,7 +44,7 @@ const setInDiscordFalseScript = async () => {
   const updateUsersPromises = [];
   users.forEach((user) => {
     const id = user.id;
-    // eslint-disable-next-line security/detect-object-injection
+
     delete user[id];
     const userData = {
       ...user,

test/fixtures/discordResponse/discord-response.js

@@ -273,7 +273,7 @@ const getOnboarding31DPlusMembers = [
     nick: "john",
     pending: false,
     premium_since: null,
-    // eslint-disable-next-line no-loss-of-precision
+
     roles: ["9876543210", "11334336"],
     user: {
       id: "9653710123456",

test/integration/contributions.test.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-unused-expressions */
 const chai = require("chai");
 const sinon = require("sinon");
 const { expect } = chai;