Revert "Fix/username validator"

Author: iamitprakash

middlewares/validators/user.js

@@ -16,8 +16,10 @@ const updateUser = async (req, res, next) => {
       username: joi
         .string()
         .optional()
-        .regex(/^[a-z]+-[a-z]+(-[1-9])?$/)
-        .message("Username must be lowercase only hypen, numbers are allowed."),
+        .min(4)
+        .max(20)
+        .regex(/^[a-zA-Z0-9]+$/)
+        .message("Username must be between 4 and 20 characters long and contain only letters or numbers."),
       first_name: joi.string().optional(),
       last_name: joi.string().optional(),
       yoe: joi.number().min(0).optional(),

test/integration/users.test.js

@@ -106,7 +106,7 @@ describe("Users", function () {
         .patch("/users/self")
         .set("cookie", `${cookieName}=${jwt}`)
         .send({
-          username: "valid-username-1",
+          username: "validUsername123",
         })
         .end((err, res) => {
           if (err) {
@@ -218,7 +218,7 @@ describe("Users", function () {
         .patch("/users/self")
         .set("cookie", `${cookieName}=${jwt}`)
         .send({
-          username: "InvalidUser-name",
+          username: "@invalidUser-name",
         })
         .end((err, res) => {
           if (err) {
@@ -230,7 +230,7 @@ describe("Users", function () {
           expect(res.body).to.eql({
             statusCode: 400,
             error: "Bad Request",
-            message: "Username must be lowercase only hypen, numbers are allowed.",
+            message: "Username must be between 4 and 20 characters long and contain only letters or numbers.",
           });
 
           return done();

test/unit/middlewares/user-validator.test.js

@@ -113,7 +113,7 @@ describe("Middleware | Validators | User", function () {
         body: {
           last_name: "patil",
           first_name: "Abhay",
-          username: "Invalidusername-12",
+          username: "@invalidusername-12",
           twitter_id: "abhayisawesome",
         },
       };