Skip to content

Commit 73986a3

Browse files
committed
resolve the comments by @Pratiyushkumar and @bhtibrewal on the PR
1 parent 31b6deb commit 73986a3

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

middlewares/validators/monitor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const baseSchema = joi
5151
})
5252
.messages({ "object.unknown": "Invalid field provided." });
5353

54-
const validateCreateTrackedProgressRecords = async (req, res, next) => {
54+
const validateCreateTrackedProgressRecord = async (req, res, next) => {
5555
const monitoredSchema = joi.object().keys({
5656
monitored: joi.boolean().required().messages({
5757
"boolean.base": "monitored field must be a boolean value.",
@@ -114,7 +114,7 @@ const validateGetTrackedProgressQueryParams = async (req, res, next) => {
114114
};
115115

116116
module.exports = {
117-
validateCreateTrackedProgressRecords,
117+
validateCreateTrackedProgressRecord,
118118
validateUpdateTrackedProgress,
119119
validateGetTrackedProgressQueryParams,
120120
};

models/monitor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const {
99
buildQueryToFetchTrackedDoc,
1010
} = require("../utils/monitor");
1111
const { RESPONSE_MESSAGES } = require("../constants/monitor");
12-
const { RESOURCE_NOT_FOUND } = RESPONSE_MESSAGES;
12+
const { RESOURCE_NOT_FOUND, RESOURCE_ALREADY_EXIST } = RESPONSE_MESSAGES;
1313

1414
/**
1515
* Creates a tracked progress document based on the provided data.
@@ -30,7 +30,7 @@ const createTrackedProgressDocument = async (documentData) => {
3030
const query = buildTrackedProgressQueryByType({ userId, taskId });
3131
const existingDocumentSnapshot = await query.get();
3232
if (!existingDocumentSnapshot.empty) {
33-
throw new Conflict("Resource is already being tracked.");
33+
throw new Conflict(RESOURCE_ALREADY_EXIST);
3434
}
3535
const timeNow = new Date().toISOString();
3636
// if not passed, the default frequency of 1 will be used as the frequency

routes/monitor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const {
99
getTrackedProgressController,
1010
} = require("../controllers/monitor");
1111
const {
12-
validateCreateTrackedProgressRecords,
12+
validateCreateTrackedProgressRecord,
1313
validateUpdateTrackedProgress,
1414
validateGetTrackedProgressQueryParams,
1515
} = require("../middlewares/validators/monitor");
@@ -18,7 +18,7 @@ router.post(
1818
"/",
1919
authenticate,
2020
authorizeRoles([SUPERUSER]),
21-
validateCreateTrackedProgressRecords,
21+
validateCreateTrackedProgressRecord,
2222
createTrackedProgressController
2323
);
2424

0 commit comments

Comments
 (0)