Skip to content

Commit 73b93b9

Browse files
committed
handle not found exception for POST request
1 parent 0374020 commit 73b93b9

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

controllers/progresses.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ const createProgress = async (req, res) => {
2424
return res.status(409).json({
2525
message: error.message,
2626
});
27+
} else if (error instanceof NotFound) {
28+
return res.status(404).json({
29+
message: error.message,
30+
});
2731
}
2832
return res.status(400).json({
2933
message: error.message,

models/progresses.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const createProgressDocument = async (progressData) => {
2929
? new Date().setUTCHours(0, 0, 0, 0) - MILLISECONDS_IN_DAY
3030
: new Date().setUTCHours(0, 0, 0, 0);
3131

32-
assertTaskExists(taskId);
32+
await assertTaskExists(taskId);
3333
const query = buildQueryForPostingProgress(progressData);
3434
const existingDocumentSnapshot = await query.where("date", "==", progressDateTimestamp).get();
3535
if (!existingDocumentSnapshot.empty) {

0 commit comments

Comments
 (0)