Skip to content

Commit 74735cd

Browse files
authored
fix: rename variable filterdUsersWithDetails with users and filteredUsernames with usernames (#1050)
1 parent eb0a1b1 commit 74735cd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

controllers/users.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,13 @@ const getUsers = async (req, res) => {
7373
if (qualifiers?.filterBy) {
7474
const allPRs = await getFilteredPRsOrIssues(qualifiers);
7575

76-
const filteredUsernames = getUsernamesFromPRs(allPRs);
76+
const usernames = getUsernamesFromPRs(allPRs);
7777

78-
const { filterdUsersWithDetails } = await userQuery.fetchUsers(filteredUsernames);
78+
const { users } = await userQuery.fetchUsers(usernames);
7979

8080
return res.json({
8181
message: "Users returned successfully!",
82-
users: filterdUsersWithDetails,
82+
users,
8383
});
8484
}
8585

models/users.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ const fetchPaginatedUsers = async (query) => {
182182
const fetchUsers = async (usernames = []) => {
183183
try {
184184
const dbQuery = userModel;
185-
const filterdUsersWithDetails = [];
185+
const users = [];
186186

187187
const groups = [];
188188
for (let i = 0; i < usernames.length; i += BATCH_SIZE_IN_CLAUSE) {
@@ -198,7 +198,7 @@ const fetchUsers = async (usernames = []) => {
198198

199199
snapshots.forEach((snapshot) => {
200200
snapshot.forEach((doc) => {
201-
filterdUsersWithDetails.push({
201+
users.push({
202202
id: doc.id,
203203
...doc.data(),
204204
phone: undefined,
@@ -210,7 +210,7 @@ const fetchUsers = async (usernames = []) => {
210210
});
211211

212212
return {
213-
filterdUsersWithDetails,
213+
users,
214214
};
215215
} catch (err) {
216216
logger.error("Error retrieving user data", err);

0 commit comments

Comments
 (0)