Skip to content

Commit 75f563c

Browse files
Removes super user authorisation for Task requests list and details API (#1683)
* chore : removes super user restriction on task requests api * chore: changes test expect for not a super user case
1 parent 0c62d57 commit 75f563c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

routes/taskRequests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ const taskRequests = require("../controllers/tasksRequests");
77
const { validateUser } = require("../middlewares/taskRequests");
88
const validators = require("../middlewares/validators/task-requests");
99

10-
router.get("/", authenticate, authorizeRoles([SUPERUSER]), validators.getTaskRequests, taskRequests.fetchTaskRequests);
11-
router.get("/:id", authenticate, authorizeRoles([SUPERUSER]), taskRequests.fetchTaskRequestById);
10+
router.get("/", authenticate, taskRequests.fetchTaskRequests);
11+
router.get("/:id", authenticate, taskRequests.fetchTaskRequestById);
1212
router.post("/addOrUpdate", authenticate, validateUser, taskRequests.addOrUpdate);
1313
router.patch("/approve", authenticate, authorizeRoles([SUPERUSER]), validateUser, taskRequests.approveTaskRequest);
1414
router.post("/", authenticate, validators.postTaskRequests, taskRequests.addTaskRequests);

test/integration/taskRequests.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ describe("Task Requests", function () {
119119
await taskRequestsModel.addOrUpdate(taskId, userId);
120120
});
121121

122-
it("should return 401 unauthorized user response", function (done) {
122+
it("should be successful when the user is not a super user", function (done) {
123123
chai
124124
.request(app)
125125
.get("/taskRequests")
@@ -129,7 +129,7 @@ describe("Task Requests", function () {
129129
return done(err);
130130
}
131131

132-
expect(res).to.have.status(401);
132+
expect(res).to.have.status(200);
133133
return done();
134134
});
135135
});
@@ -196,7 +196,7 @@ describe("Task Requests", function () {
196196
await taskRequestsModel.addOrUpdate(taskId, userId);
197197
});
198198

199-
it("should return 401 status code", function (done) {
199+
it("should be successful when the user is not a super user", function (done) {
200200
chai
201201
.request(app)
202202
.get(`/taskRequests/taskrequstid`)
@@ -206,7 +206,7 @@ describe("Task Requests", function () {
206206
return done(err);
207207
}
208208

209-
expect(res).to.have.status(401);
209+
expect(res).to.have.status(200);
210210
return done();
211211
});
212212
});

0 commit comments

Comments
 (0)