handles internal server error gracefully

Author: heyrandhir

constants/progresses.js

@@ -3,6 +3,8 @@ const PROGRESS_DOCUMENT_RETRIEVAL_SUCCEEDED = "Progress document retrieved succe
 const PROGRESS_DOCUMENT_NOT_FOUND = "No progress records found.";
 const PROGRESS_ALREADY_CREATED = "Progress for the day has already been created.";
 const MILLISECONDS_IN_DAY = 24 * 60 * 60 * 1000;
+const INTERNAL_SERVER_ERROR_MESSAGE =
+  "The server has encountered an unexpected error. Please contact the administrator for more information.";
 
 const RESPONSE_MESSAGES = {
   PROGRESS_DOCUMENT_CREATED_SUCCEEDED,
@@ -11,4 +13,4 @@ const RESPONSE_MESSAGES = {
   PROGRESS_ALREADY_CREATED,
 };
 
-module.exports = { RESPONSE_MESSAGES, MILLISECONDS_IN_DAY };
+module.exports = { RESPONSE_MESSAGES, MILLISECONDS_IN_DAY, INTERNAL_SERVER_ERROR_MESSAGE };

controllers/progresses.js

@@ -1,6 +1,6 @@
 const { Conflict, NotFound } = require("http-errors");
 const { createProgressDocument, getProgressDocument, getRangeProgressData } = require("../models/progresses");
-const { RESPONSE_MESSAGES } = require("../constants/progresses");
+const { RESPONSE_MESSAGES, INTERNAL_SERVER_ERROR_MESSAGE } = require("../constants/progresses");
 const { PROGRESS_DOCUMENT_RETRIEVAL_SUCCEEDED, PROGRESS_DOCUMENT_CREATED_SUCCEEDED } = RESPONSE_MESSAGES;
 
 /**
@@ -58,8 +58,9 @@ const createProgress = async (req, res) => {
         message: error.message,
       });
     }
-    return res.status(400).json({
-      message: error.message,
+    logger.error(error.message);
+    return res.status(500).json({
+      message: INTERNAL_SERVER_ERROR_MESSAGE,
     });
   }
 };
@@ -112,8 +113,9 @@ const getProgress = async (req, res) => {
         message: error.message,
       });
     }
-    return res.status(400).json({
-      message: error.message,
+    logger.error(error.message);
+    return res.status(500).json({
+      message: INTERNAL_SERVER_ERROR_MESSAGE,
     });
   }
 };
@@ -165,8 +167,9 @@ const getProgressRangeData = async (req, res) => {
         message: error.message,
       });
     }
-    return res.status(400).json({
-      message: error.message,
+    logger.error(error.message);
+    return res.status(500).json({
+      message: INTERNAL_SERVER_ERROR_MESSAGE,
     });
   }
 };