Skip to content

Commit 8d40ebc

Browse files
refactor: update remaining parseInt to Number.parseInt for ES2015+ compliance
1 parent cd129fb commit 8d40ebc

File tree

10 files changed

+1617
-1585
lines changed

10 files changed

+1617
-1585
lines changed

controllers/auction.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const createNewAuction = async (req, res) => {
5353
const { initial_price: initialPrice, item_type: itemType, end_time: endTime, quantity } = req.body;
5454

5555
const { currencies } = await wallet.fetchWallet(seller);
56-
const itemQuantity = parseInt(currencies[`${itemType}`]);
56+
const itemQuantity = Number.parseInt(currencies[`${itemType}`]);
5757
if (!itemQuantity || itemQuantity < quantity) return res.boom.forbidden(`You do not have enough of ${itemType}s!`);
5858

5959
const auctionId = await auctions.createNewAuction({ seller, initialPrice, itemType, endTime, quantity });

controllers/discordactions.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ const deleteGroupRole = async (req, res) => {
127127
const getPaginatedAllGroupRoles = async (req, res) => {
128128
try {
129129
const { page = 0, size = 10, dev } = req.query;
130-
const limit = parseInt(size, 10) || 10;
131-
const offset = parseInt(page, 10) * limit;
130+
const limit = Number.parseInt(size, 10) || 10;
131+
const offset = Number.parseInt(page, 10) * limit;
132132

133133
if (limit < 1 || limit > 100) {
134134
return res.boom.badRequest("Invalid size. Must be between 1 and 100.");
@@ -139,8 +139,8 @@ const getPaginatedAllGroupRoles = async (req, res) => {
139139
const { roles, total } = await discordRolesModel.getPaginatedGroupRolesByPage({ offset, limit });
140140
const groupsWithMembershipInfo = await discordRolesModel.enrichGroupDataWithMembershipInfo(discordId, roles);
141141

142-
const nextPage = offset + limit < total ? parseInt(page, 10) + 1 : null;
143-
const prevPage = page > 0 ? parseInt(page, 10) - 1 : null;
142+
const nextPage = offset + limit < total ? Number.parseInt(page, 10) + 1 : null;
143+
const prevPage = page > 0 ? Number.parseInt(page, 10) - 1 : null;
144144

145145
const baseUrl = `${req.baseUrl}${req.path}`;
146146
const next = nextPage !== null ? `${baseUrl}?page=${nextPage}&size=${limit}&dev=true` : null;

controllers/profileDiffs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const getProfileDiffs = async (req, res) => {
2222
const { profileDiffs, next } = await profileDiffsQuery.fetchProfileDiffsWithPagination(
2323
status,
2424
order,
25-
parseInt(size),
25+
Number.parseInt(size),
2626
username,
2727
cursor
2828
);

controllers/progresses.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,10 @@ const getProgress = async (req, res) => {
116116
try {
117117
if (dev === "true") {
118118
const { progressDocs, totalProgressCount } = await progressesModel.getPaginatedProgressDocument(req.query);
119-
const limit = parseInt(size, 10);
120-
const offset = parseInt(page, 10) * limit;
121-
const nextPage = offset + limit < totalProgressCount ? parseInt(page, 10) + 1 : null;
122-
const prevPage = page > 0 ? parseInt(page, 10) - 1 : null;
119+
const limit = Number.parseInt(size, 10);
120+
const offset = Number.parseInt(page, 10) * limit;
121+
const nextPage = offset + limit < totalProgressCount ? Number.parseInt(page, 10) + 1 : null;
122+
const prevPage = page > 0 ? Number.parseInt(page, 10) - 1 : null;
123123
let baseUrl = `${req.baseUrl}`;
124124
if (type) {
125125
baseUrl += `?type=${type}`;

controllers/users.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -928,8 +928,8 @@ const filterUsers = async (req, res) => {
928928
});
929929
}
930930
const { page, size } = req.query;
931-
const pageNumber = parseInt(page) || 0;
932-
const limitNumber = parseInt(size) || 100;
931+
const pageNumber = Number.parseInt(page) || 0;
932+
const limitNumber = Number.parseInt(size) || 100;
933933
const skip = (pageNumber - 1) * limitNumber;
934934

935935
const users = await dataAccess.retreiveFilteredUsers(req.query, skip, limitNumber);

utils/extensionRequests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const transformQuery = (size, status, dev = false) => {
2828

2929
let transformedSize;
3030
if (size) {
31-
transformedSize = parseInt(size);
31+
transformedSize = Number.parseInt(size);
3232
}
3333
let transformedStatus;
3434

utils/progresses.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ const buildQueryToFetchPaginatedDocs = async (queryParams) => {
133133
const { type, userId, taskId, orderBy, size = PROGRESSES_SIZE, page = PROGRESSES_PAGE_SIZE } = queryParams;
134134
const orderByField = PROGRESS_VALID_SORT_FIELDS[0];
135135
const isAscOrDsc = orderBy && PROGRESS_VALID_SORT_FIELDS[0] === orderBy ? "asc" : "desc";
136-
const limit = parseInt(size, 10);
137-
const offset = parseInt(page, 10) * limit;
136+
const limit = Number.parseInt(size, 10);
137+
const offset = Number.parseInt(page, 10) * limit;
138138

139139
let baseQuery;
140140
if (type) {

utils/tasks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ const transformQuery = (status = "", size, page, assignee = "", title = "") => {
7474
const transformedTitle = title;
7575

7676
if (page) {
77-
query.page = parseInt(page);
77+
query.page = Number.parseInt(page);
7878
}
7979

8080
if (size) {
81-
query.size = parseInt(size);
81+
query.size = Number.parseInt(size);
8282
}
8383

8484
return {

utils/users.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ const parseSearchQuery = (queryString) => {
217217
searchParams.filterBy = value.toLowerCase();
218218
break;
219219
case "days":
220-
searchParams.days = parseInt(value);
220+
searchParams.days = Number.parseInt(value);
221221
break;
222222
default:
223223
break;

0 commit comments

Comments
 (0)