Skip to content

Commit 90b1c5e

Browse files
committed
refactor test: use template strings to match called url
1 parent 10afc71 commit 90b1c5e

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

test/unit/services/githubService.test.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,17 @@ describe("githubService", function () {
141141

142142
describe("fetchOpenIssues with search query param", function () {
143143
it("Should generate the correct url to fetch open issues with search param", async function () {
144+
const searchString = "website";
144145
const response = await githubService.fetchOpenIssues({
145-
searchString: "website",
146+
searchString,
146147
});
147-
expect(response).to.be.equal(
148-
"https://api.github.com/search/issues?q=website+org%3AReal-Dev-Squad+type%3Aissue+is%3Aopen&sort=created&per_page=100&page=1"
149-
);
148+
149+
const baseURL = config.get("githubApi.baseUrl");
150+
const org = config.get("githubApi.org");
151+
const path = "search/issues";
152+
const searchParams = `org%3A${org}+type%3Aissue+is%3Aopen&sort=created&per_page=100&page=1`;
153+
154+
expect(response).to.be.equal(`${baseURL}/${path}?q=${searchString}+${searchParams}`);
150155
});
151156
});
152157
});

0 commit comments

Comments
 (0)