fix: getUsernameFromPRs to return users in orders

Author: khalatevarun

controllers/users.js

@@ -8,7 +8,7 @@ const { logType } = require("../constants/logs");
 const { fetch } = require("../utils/fetch");
 const logger = require("../utils/logger");
 const obfuscate = require("../utils/obfuscate");
-const { getPaginationLink, getFilteredUsernames } = require("../utils/users");
+const { getPaginationLink, getUsernamesFromPRs } = require("../utils/users");
 const { getQualifiers } = require("../utils/helper");
 const { SOMETHING_WENT_WRONG, INTERNAL_SERVER_ERROR } = require("../constants/errorMessages");
 const { getFilteredPRsOrIssues } = require("../utils/pullRequests");
@@ -73,7 +73,7 @@ const getUsers = async (req, res) => {
     if (qualifiers?.filterBy) {
       const allPRs = await getFilteredPRsOrIssues(qualifiers);
 
-      const filteredUsernames = getFilteredUsernames(allPRs);
+      const filteredUsernames = getUsernamesFromPRs(allPRs);
 
       const { filterdUsersWithDetails } = await userQuery.fetchUsers(filteredUsernames);
 

utils/users.js

@@ -121,14 +121,18 @@ function getPaginationLink(query, cursor, documentId) {
  * @param allUsers {Array} - list of total users from firebase
  *
  */
-function getFilteredUsernames(allPRs) {
-  const uniqueUsersInOrder = new Set();
+function getUsernamesFromPRs(allPRs) {
+  const uniqueUsernamesSet = new Set();
+  const usernames = [];
 
-  allPRs?.forEach((element) => {
-    uniqueUsersInOrder.add(element.username);
+  allPRs?.forEach((pr) => {
+    if (!uniqueUsernamesSet.has(pr.username)) {
+      uniqueUsernamesSet.add(pr.username);
+      usernames.push(pr.username);
+    }
   });
 
-  return Array.from(uniqueUsersInOrder);
+  return usernames;
 }
 
 module.exports = {
@@ -138,5 +142,5 @@ module.exports = {
   getParticipantUsernames,
   getLowestLevelSkill,
   getPaginationLink,
-  getFilteredUsernames,
+  getUsernamesFromPRs,
 };