chore: fix test and error message

Author: vinit717

controllers/logs.js

@@ -67,6 +67,9 @@ const fetchAllLogs = async (req, res) => {
       prev: prevUrl,
     });
   } catch (err) {
+    if (err.statusCode) {
+      return res.status(err.statusCode).json({ error: err.message });
+    }
     logger.error(ERROR_WHILE_FETCHING_LOGS, err);
     return res.boom.badImplementation(ERROR_WHILE_FETCHING_LOGS);
   }

models/logs.js

@@ -188,7 +188,9 @@ const fetchAllLogs = async (query) => {
       endDate = endDate ? parseInt(endDate) : null;
 
       if (startDate && endDate && startDate > endDate) {
-        throw new Error("Start date cannot be greater than end date.");
+        const error = new Error("Start date cannot be greater than end date.");
+        error.statusCode = 400;
+        throw error;
       }
 
       const buildTimestamp = (date) => ({

test/integration/logs.test.js

@@ -241,7 +241,7 @@ describe("/logs", function () {
         .get(`/logs?username=${username}&startDate=${startDate}&endDate=${endDate}&dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
         .end(function (_err, res) {
-          expect(res).to.have.status(500);
+          expect(res).to.have.status(400);
           expect(res.body.error).to.equal("Start date cannot be greater than end date.");
           return done();
         });