fix: test case

Author: surajmaity1

test/fixtures/oooRequest/oooRequest.ts

@@ -164,7 +164,7 @@ export const createOooRequests3 = {
   from: Date.now() + 100000,
   until: Date.now() + 200000,
   type: "OOO",
-  requestedBy: "testUser",
+  requestedBy: "suraj-maity-1",
   reason: "Out of office for personal emergency.",
   status: REQUEST_STATE.PENDING
 };

test/integration/requests.test.ts

@@ -1,6 +1,5 @@
 import chai from "chai";
 const { expect } = chai;
-import sinon from "sinon";
 import chaiHttp from "chai-http";
 import _ from "lodash";
 import config from "config";
@@ -30,7 +29,8 @@ import {
   REQUEST_ALREADY_PENDING,
   REQUEST_REJECTED_SUCCESSFULLY,
   REQUEST_ALREADY_REJECTED,
-  // UNAUTHORIZED_TO_ACKNOWLEDGE_OOO_REQUEST,
+  INVALID_REQUEST_TYPE,
+  UNAUTHORIZED_TO_ACKNOWLEDGE_OOO_REQUEST,
   // UNAUTHORIZED_TO_CREATE_OOO_REQUEST,
   // USER_STATUS_NOT_FOUND,
   // OOO_STATUS_ALREADY_EXIST,
@@ -40,6 +40,7 @@ import { validTaskAssignmentRequest, validTaskCreqtionRequest } from "../fixture
 import { deleteUserStatus, updateUserStatus } from "../../models/userStatus";
 import * as requestsQuery from "../../models/requests";
 import { userState } from "../../constants/userStatus";
+import * as logUtils from "../../services/logService";
 
 const userData = userDataFixture();
 chai.use(chaiHttp);
@@ -55,7 +56,7 @@ let testUserId: string;
 let testSuperUserId: string;
 let testArchivedUserId: string;
 
-describe("/requests OOO", function () {
+describe.only("/requests OOO", function () {
 
   const requestsEndpoint: string = "/requests?dev=true";
 
@@ -322,15 +323,15 @@ describe("/requests OOO", function () {
     });
   });
 
-  describe.skip("PATCH /requests/:id", function () {
+  describe("PATCH /requests/:id", function () {
     let pendingOooRequestId1: string;
     let oooRequestData3: any;
     let invalidRequestId: string;
     let approvedOooRequestId: string;
     let rejectedOooRequestId: string;
 
     beforeEach(async function () {
-      oooRequestData3 = { ...createOooRequests3, requestedBy: testUserId };
+      oooRequestData3 = { ...createOooRequests3, userId: testUserId };
 
       const { id: pendingOooId1 }: any = await createRequest(oooRequestData3);
       pendingOooRequestId1 = pendingOooId1;
@@ -394,7 +395,7 @@ describe("/requests OOO", function () {
         });
     });
 
-    it("should return 401 if user does not have super user permission", function (done) {
+    it("should return 403 if user does not have super user permission", function (done) {
       chai
         .request(app)
         .patch(`/requests/${pendingOooRequestId1}?dev=true`)
@@ -404,13 +405,13 @@ describe("/requests OOO", function () {
           if (err) {
             return done(err);
           }
-          expect(res.statusCode).to.equal(401);
-          // expect(res.body.message).to.equal(UNAUTHORIZED_TO_ACKNOWLEDGE_OOO_REQUEST);
+          expect(res.statusCode).to.equal(403);
+          expect(res.body.message).to.equal(UNAUTHORIZED_TO_ACKNOWLEDGE_OOO_REQUEST);
           done();
         });
     });
 
-    it("should return 400 if OOO request is already approved", function (done) {
+    it("should return 409 if OOO request is already approved", function (done) {
       chai
         .request(app)
         .patch(`/requests/${approvedOooRequestId}?dev=true`)
@@ -420,13 +421,13 @@ describe("/requests OOO", function () {
           if (err) {
             return done(err);
           }
-          expect(res.statusCode).to.equal(400);
+          expect(res.statusCode).to.equal(409);
           expect(res.body.message).to.equal(REQUEST_ALREADY_APPROVED);
           done();
         });
     });
 
-    it("should return 400 if OOO request is already rejected", function (done) {
+    it("should return 409 if OOO request is already rejected", function (done) {
       chai
         .request(app)
         .patch(`/requests/${rejectedOooRequestId}?dev=true`)
@@ -436,7 +437,7 @@ describe("/requests OOO", function () {
           if (err) {
             return done(err);
           }
-          expect(res.statusCode).to.equal(400);
+          expect(res.statusCode).to.equal(409);
           expect(res.body.message).to.equal(REQUEST_ALREADY_REJECTED);
           done();
         });

test/unit/middlewares/oooRequests.test.ts

@@ -4,7 +4,7 @@ const { expect } = chai;
 
 import {
   createOooStatusRequestValidator,
-  // acknowledgeOOORequestsValidator,
+  acknowledgeOOORequestsValidator,
 } from "./../../../middlewares/validators/oooRequests";
 import { acknowledgeOooRequest, validOooStatusRequests, validOooStatusUpdate } from "../../fixtures/oooRequest/oooRequest";
 import _ from "lodash";
@@ -93,39 +93,39 @@ describe("OOO Status Request Validators", function () {
   });
 
   describe("acknowledgeOOORequestsValidator", function () {
-    it.skip("should not validate for an invalid request for invalid request type", async function () {
+    it("should not validate for an invalid request for invalid request type", async function () {
       req = {
         body: { ...acknowledgeOooRequest, type: "XYZ"}
       };
 
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOOORequestsValidator(req, res, nextSpy);
       expect(nextSpy.notCalled).to.be.true;
     });
 
-    it.skip("should not validate for an invalid request if status is incorrect", async function () {
+    it("should not validate for an invalid request if status is incorrect", async function () {
       req = {
         body: { ...acknowledgeOooRequest, status: "PENDING"}
       };
 
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOOORequestsValidator(req, res, nextSpy);
       expect(nextSpy.notCalled).to.be.true;
     });
 
-    it.skip("should validate for a valid acknowledge OOO request if comment not provided by superusers", async function() {
+    it("should validate for a valid acknowledge OOO request if comment not provided by superusers", async function() {
       req = {
         body: _.omit(acknowledgeOooRequest, "comment")
       };
       res = {};
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOOORequestsValidator(req, res, nextSpy);
       expect(nextSpy.calledOnce).to.be.true;
     });
 
-    it.skip("should validate for a valid acknowledge OOO request", async function() {
+    it("should validate for a valid acknowledge OOO request", async function() {
       req = {
         body: acknowledgeOooRequest
       };
       res = {};
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOOORequestsValidator(req, res, nextSpy);
       expect(nextSpy.calledOnce).to.be.true;
     });
   });