refactor code

Author: vinit717

controllers/tasks.js

@@ -28,25 +28,15 @@ const addNewTask = async (req, res) => {
       taskId,
       dependsOn,
     };
-    if (data.dependsOn) {
-      const taskDependency = await dependencyModel.addDependency(data);
-      return res.json({
-        message: "Task created successfully!",
-        task: {
-          ...taskDetails,
-          dependsOn: taskDependency,
-          id: taskId,
-        },
-      });
-    } else {
-      return res.json({
-        message: "Task created successfully!",
-        task: {
-          ...taskDetails,
-          id: taskId,
-        },
-      });
-    }
+    const taskDependency = dependsOn && (await dependencyModel.addDependency(data));
+    return res.json({
+      message: "Task created successfully!",
+      task: {
+        ...taskDetails,
+        ...(taskDependency && { dependsOn: taskDependency }),
+        id: taskId,
+      },
+    });
   } catch (err) {
     logger.error(`Error while creating new task: ${err}`);
     return res.boom.badImplementation(INTERNAL_SERVER_ERROR);

models/tasks.js

@@ -43,6 +43,9 @@ const addDependency = async (data) => {
   try {
     const { taskId, dependsOn } = data;
     const batch = firestore.batch();
+    if (dependsOn.length > 500) {
+      throw new Error("Error cannot add more than 500 taskId");
+    }
     for (const dependsId of dependsOn) {
       const taskDependOn = {
         taskId,

test/integration/tasks.test.js

@@ -106,8 +106,8 @@ describe("Tasks", function () {
           expect(res).to.have.status(200);
           expect(res.body).to.be.a("object");
           expect(res.body.message).to.equal("Task created successfully!");
-          expect(res.body.task.id).to.be.a("string");
           expect(res.body.task).to.be.a("object");
+          expect(res.body.task.id).to.be.a("string");
           expect(res.body.task.createdBy).to.equal(appOwner.username);
           expect(res.body.task.assignee).to.equal(appOwner.username);
           expect(res.body.task.participants).to.be.a("array");