fixes unnecessary array check in arraysHaveCommonItem

heyrandhir · heyrandhir · commit c2425a525f5e · 2023-04-05T22:13:02.000+05:30
diff --git a/utils/array.js b/utils/array.js
@@ -26,7 +26,7 @@ function chunks(array, size = 1) {
  */
 
 function arraysHaveCommonItem(array1, array2) {
-  if (!Array.isArray(array1) || !Array.isArray(array2) || !array1.length || !array2.length) {
+  if (!array1?.length || !array2?.length) {
     return false;
   }
   return array1.some((value) => array2.includes(value));

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ function chunks(array, size = 1) {`
`26`	`26`	`*/`
`27`	`27`
`28`	`28`	`function arraysHaveCommonItem(array1, array2) {`
`29`		`- if (!Array.isArray(array1) \|\| !Array.isArray(array2) \|\| !array1.length \|\| !array2.length) {`
	`29`	`+ if (!array1?.length \|\| !array2?.length) {`
`30`	`30`	`return false;`
`31`	`31`	`}`
`32`	`32`	`return array1.some((value) => array2.includes(value));`