made requested changes

Author: swarajpure

controllers/challengeController.js

@@ -1,6 +1,6 @@
 const challengeQuery = require('../models/challenges')
 
-const errorAdminString = 'Something went wrong. Please try again or contact admin'
+const ERRORADMINSTRING = 'Something went wrong. Please try again or contact admin'
 
 /**
  * Get the challenges or add the challenge
@@ -33,11 +33,11 @@ const sendChallengeResponse = async (req, res) => {
         return res.boom.notFound('Unable to add challenge')
       }
     }
+    return ''
   } catch (err) {
     logger.error(`Error while retriving challenges ${err}`)
-    return res.boom.serverUnavailable(errorAdminString)
+    return res.boom.serverUnavailable(ERRORADMINSTRING)
   }
-  return ''
 }
 
 /**
@@ -59,7 +59,7 @@ const subscribeToChallenge = async (req, res) => {
     }
   } catch (err) {
     logger.error(`Error while retrieving challenges ${err}`)
-    return res.boom.serverUnavailable(errorAdminString)
+    return res.boom.serverUnavailable(ERRORADMINSTRING)
   }
 }
 

models/challenges.js

@@ -9,9 +9,9 @@ const firestore = require('../utils/firestore')
 const challengesModel = firestore.collection('challenges')
 const userModel = firestore.collection('users')
 
-const cannotSubscribe = 'User cannot be subscribed to challenge'
-const userDoesNotExistError = 'User does not exist. Please register to participate'
-const errorMessage = 'Error getting challenges'
+const CANNOTSUBSCRIBE = 'User cannot be subscribed to challenge'
+const USERDOESNOTEXISTERROR = 'User does not exist. Please register to participate'
+const ERRORMESSAGE = 'Error getting challenges'
 
 /**
  * Fetch the challenges
@@ -21,18 +21,16 @@ const errorMessage = 'Error getting challenges'
 const fetchChallenges = async () => {
   try {
     const challengesSnapshot = await challengesModel.get()
-    return (function () {
-      const challenges = []
-      challengesSnapshot.forEach((challengeDoc) => {
-        challenges.push({
-          id: challengeDoc.id,
-          ...challengeDoc.data()
-        })
+    const challenges = []
+    challengesSnapshot.forEach((challengeDoc) => {
+      challenges.push({
+        id: challengeDoc.id,
+        ...challengeDoc.data()
       })
-      return challenges
-    })()
+    })
+    return challenges
   } catch (err) {
-    logger.error(errorMessage, err)
+    logger.error(ERRORMESSAGE, err)
     throw err
   }
 }
@@ -54,7 +52,7 @@ const postChallenge = async (challengeData) => {
       return allChallenges
     } else return ''
   } catch (err) {
-    logger.error(errorMessage, err)
+    logger.error(ERRORMESSAGE, err)
     throw err
   }
 }
@@ -74,10 +72,10 @@ const subscribeUserToChallenge = async (userId, challengeId) => {
       await challengeRef.update({ participants: Firestore.FieldValue.arrayUnion({ name: user }) })
       return challengeRef.get()
     } else {
-      throw new Error(userDoesNotExistError)
+      throw new Error(USERDOESNOTEXISTERROR)
     }
   } catch (err) {
-    logger.error(cannotSubscribe, err)
+    logger.error(CANNOTSUBSCRIBE, err)
     throw err
   }
 }

routes/challenges.js

@@ -5,7 +5,7 @@ const challengesController = require('../controllers/challengeController')
 
 /**
  * @swagger
- * /challenges/:
+ * /challenges:
  *   get:
  *     summary: Used to get all the challenges
  *     tags: