write test for brew install redis

Author: bhtibrewal

models/users.js

@@ -428,19 +428,19 @@ const getUsersBasedOnFilter = async (query) => {
       });
     });
 
-    return filteredUsers;
+    return filteredUsers.filter((user) => !user.roles?.archived);
   }
-  if (verifiedQuery) {
+  if (verifiedQuery === "true") {
     const filteredUsers = [];
-    const snapshot = await userModel.orderBy("discordId").get();
+    const snapshot = await userModel.where("discordId", "!=", null).get();
     snapshot.forEach((doc) => {
       filteredUsers.push({
         id: doc.id,
         ...doc.data(),
       });
     });
 
-    return filteredUsers;
+    return filteredUsers.filter((user) => !user.roles?.archived);
   }
   return [];
 };

test/fixtures/user/user.js

@@ -21,8 +21,10 @@ module.exports = () => {
       isMember: true,
       phone: "1234567890",
       email: "[email protected]",
+      joined_discord: "2023-01-13T18:21:09.278000+00:00",
       roles: {
         member: true,
+        in_discord: true,
       },
       tokens: {
         githubAccessToken: "githubAccessToken",
@@ -105,13 +107,15 @@ module.exports = () => {
       github_display_name: "Ankush Dharkar",
       phone: "1234567890",
       email: "[email protected]",
+      joined_discord: "2023-01-13T18:21:09.278000+00:00",
       status: "idle",
       tokens: {
         githubAccessToken: "githubAccessToken",
       },
       roles: {
         super_user: true,
         archived: false,
+        in_discord: true,
       },
       picture: {
         publicId: "profile/mtS4DhUvNYsKqI7oCWVB/aenklfhtjldc5ytei3ar",

test/unit/models/users.test.js

@@ -88,4 +88,16 @@ describe("users", function () {
       expect(userExists).to.equal(true);
     });
   });
+
+  describe("brew install redis", function () {
+    it("should return an empty array if no query is provided", async function () {
+      const result = await users.getUsersBasedOnFilter({});
+      expect(result).to.deep.equal([]);
+    });
+
+    it("should return an array of verified users", async function () {
+      const result = await users.getUsersBasedOnFilter({ verified: "true" });
+      expect(result).to.deep.equal(userDataArray.filter((user) => user.discordId));
+    });
+  });
 });