refactor: update import/export syntax and improve error handling in various files

Author: prakashchoudhary07

.gitignore

@@ -124,5 +124,6 @@ dist
 
 # Local config file
 config/local.js
+config/local.cjs
 
-package-lock.json
+package-lock.json

app.ts

@@ -28,7 +28,7 @@ app.use(function (err, req, res, next) {
   if (isMulterError(err)) {
     return multerErrorHandling(err, req, res, next);
   }
-  logger.error(err);
+  console.error(err); // TODO: add logger here
   return res.boom.boomify(err, {
     statusCode: err.statusCode,
   });

controllers/events.js

@@ -2,7 +2,7 @@ import logger from "../utils/logger.js";
 import { GET_ALL_EVENTS_LIMIT_MIN, UNWANTED_PROPERTIES_FROM_100MS, EVENT_ROLES } from "../constants/events.js";
 import { INTERNAL_SERVER_ERROR } from "../constants/errorMessages.js";
 import { EventTokenService, EventAPIService } from "../services/index.js";
-import { createEvent as createEventQuery, getEventCodes } from "../models/events.js";
+import { createEvent as createEventQuery, getEventCodes as getEventCodesQuery } from "../models/events.js";
 import { removeUnwantedProperties } from "../utils/events.js";
 import crypto from "crypto";
 import { addLog } from "../models/logs.js";
@@ -97,7 +97,7 @@ const joinEvent = async (req, res) => {
 
   try {
     if (role === EVENT_ROLES.MAVEN) {
-      const eventCodes = await getEventCodes({ id: roomId });
+      const eventCodes = await getEventCodesQuery({ id: roomId });
       const allEventCodesArray = eventCodes.map((eventCode) => {
         return eventCode.code;
       });
@@ -344,6 +344,35 @@ const generateEventCode = async (req, res) => {
   }
 };
 
+/**
+ * Gets event codes for particular event
+ *
+ * @async
+ * @function
+ * @param {Object} req - The Express request object.
+ * @param {Object} res - The Express response object.
+ * @returns {Promise<Object>} The JSON response with a success message if the event codes are fetched succesfully
+ * @throws {Object} The JSON response with an error message if an error occurred while getting the event codes data
+ */
+const getEventCodes = async (req, res) => {
+  const { id } = req.params;
+
+  try {
+    const eventCodes = await getEventCodesQuery({ id });
+
+    return res.status(200).json({
+      message: "Event codes is successfully fetched for the event!",
+      data: eventCodes,
+    });
+  } catch (error) {
+    logger.error({ error });
+    return res.status(500).json({
+      error: error.code,
+      message: "Something went wrong while getting the event codes!",
+    });
+  }
+};
+
 export default {
   createEvent,
   getAllEvents,
@@ -352,6 +381,7 @@ export default {
   updateEvent,
   endActiveEvent,
   addPeerToEvent,
+  getEventCodes,
   kickoutPeer,
   generateEventCode,
 };

middlewares/taskRequests.js

@@ -34,6 +34,4 @@ async function validateUser(req, res, next) {
   }
 }
 
-export default {
-  validateUser,
-};
+export { validateUser };

middlewares/validators/members.js

@@ -15,6 +15,4 @@ const validateGetMembers = async (req, res, next) => {
   }
 };
 
-export default {
-  validateGetMembers,
-};
+export { validateGetMembers };

middlewares/validators/recruiter.js

@@ -22,6 +22,4 @@ const validateRecruiter = async (req, res, next) => {
   }
 };
 
-export default {
-  validateRecruiter,
-};
+export { validateRecruiter };

middlewares/validators/stocks.js

@@ -17,6 +17,4 @@ const createStock = async (req, res, next) => {
   }
 };
 
-export default {
-  createStock,
-};
+export { createStock };

routes/applications.ts

@@ -4,9 +4,9 @@ import express from "express";
 import { ROLES } from "../constants/roles.js";
 import authenticate from "../middlewares/authenticate.js";
 import { authorizeRoles } from "../middlewares/authorizeRoles.js";
-import * as applications from "../controllers/applications.js";
+import { getAllOrUserApplication, addNewApplication, updateApplicationStatus } from "../controllers/applications.js";
 import { authorizeOwnOrSuperUser } from "../middlewares/authorizeOwnOrSuperUser.js";
-import * as applicationValidator from "../middlewares/validators/application.js";
+import applicationValidator from "../middlewares/validators/application.js";
 
 const router = express.Router();
 
@@ -15,16 +15,16 @@ router.get(
   authenticate,
   authorizeOwnOrSuperUser,
   applicationValidator.validateApplicationQueryParam,
-  applications.getAllOrUserApplication
+  getAllOrUserApplication
 );
-router.get("/:applicationId", authenticate, authorizeRoles([ROLES.SUPERUSER]), applications.getApplicationById);
-router.post("/", authenticate, applicationValidator.validateApplicationData, applications.addApplication);
+// router.get("/:applicationId", authenticate, authorizeRoles([ROLES.SUPERUSER]), getApplicationById);
+router.post("/", authenticate, applicationValidator.validateApplicationData, addNewApplication);
 router.patch(
   "/:applicationId",
   authenticate,
   authorizeRoles([ROLES.SUPERUSER]),
   applicationValidator.validateApplicationUpdateData,
-  applications.updateApplication
+  updateApplicationStatus
 );
 
 export default router;

routes/fcmToken.js

@@ -5,6 +5,6 @@ import { fcmTokenValidator } from "../middlewares/validators/fcmToken.js";
 
 const router = express.Router();
 
-router.post("/", authenticate, fcmTokenValidator.validateFcmToken, fcmTokenController);
+router.post("/", authenticate, fcmTokenValidator, fcmTokenController);
 
 export default router;

routes/index.ts

@@ -55,12 +55,12 @@ appRoutes.use("/challenges", challenges);
 appRoutes.use("/contributions", contributions);
 appRoutes.use("/healthcheck", healthCheck);
 appRoutes.use("/logs", logs);
-// appRoutes.use("/members", members);
+appRoutes.use("/members", members);
 appRoutes.use("/pullrequests", pullRequests);
 appRoutes.use("/questions", questions);
-// appRoutes.use("/stocks", stocks);
+appRoutes.use("/stocks", stocks);
 appRoutes.use("/tasks", tasks);
-// appRoutes.use("/taskRequests", taskRequests);
+appRoutes.use("/taskRequests", taskRequests);
 appRoutes.use("/trade", trading);
 appRoutes.use("/users/status", userStatus);
 appRoutes.use("/users", users);
@@ -72,14 +72,14 @@ appRoutes.use("/levels", levels);
 appRoutes.use("/items", items);
 appRoutes.use("/cache", cloudflareCache);
 appRoutes.use("/external-accounts", externalAccounts);
-// appRoutes.use("/events", events);
+appRoutes.use("/events", events);
 appRoutes.use("/discord-actions", discordActions);
 appRoutes.use("/issues", issues);
 appRoutes.use("/progresses", progresses);
 appRoutes.use("/monitor", monitor);
 appRoutes.use("/staging", staging);
-// appRoutes.use("/applications", applications);
-// appRoutes.use("/v1/fcm-tokens", fcmToken);
+appRoutes.use("/applications", applications);
+appRoutes.use("/v1/fcm-tokens", fcmToken);
 appRoutes.use("/v1/notifications", notify);
 appRoutes.use("/goals", goals);
 appRoutes.use("/invites", invites);