Fix/Get users by status api performance (#1928)

* fix: GET users by status api performance improvement

* fix: remove empty line

* refactor: refactored promises

* fix: comment fix

Author: Saransh29

controllers/userStatus.js

@@ -74,15 +74,18 @@ const getAllUserStatus = async (req, res) => {
   try {
     const { allUserStatus } = await userStatusModel.getAllUserStatus(req.query);
     const activeUsers = [];
-    for (const status of allUserStatus) {
-      //  fetching users from users collection by userID in userStatus collection
-      const result = await dataAccess.retrieveUsers({ id: status.userId });
-      if (!result.user?.roles?.archived) {
-        status.full_name = `${result.user.first_name} ${result.user.last_name}`;
-        status.picture = result.user.picture;
-        status.username = result.user.username;
-        activeUsers.push(status);
-      }
+    if (allUserStatus) {
+      const allUsersStatusFetchPromises = allUserStatus.map(async (status) => {
+        //  fetching users from users collection with the help of userID in userStatus collection
+        const result = await dataAccess.retrieveUsers({ id: status.userId });
+        if (!result.user?.roles?.archived) {
+          status.full_name = `${result.user.first_name} ${result.user.last_name}`;
+          status.picture = result.user.picture;
+          status.username = result.user.username;
+          activeUsers.push(status);
+        }
+      });
+      await Promise.all(allUsersStatusFetchPromises);
     }
     return res.json({
       message: "All User Status found successfully.",