Skip to content

Commit de9ca5b

Browse files
committed
fix: tests
1 parent f56a0d0 commit de9ca5b

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

controllers/tasksRequests.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@ const fetchTaskRequestById = async (req, res) => {
2828
const id = req.params.id;
2929
const data = await taskRequestsModel.fetchTaskRequestById(id);
3030

31-
if (data.taskRequestExists) {
32-
res.status(200).json({
33-
message: "Task request returned successfully",
34-
data: data.taskRequestData,
31+
if (!data.taskRequestExists) {
32+
return res.status(404).json({
33+
message: "Task request not found",
3534
});
3635
}
37-
38-
return res.status(404).json({
39-
message: "Task request not found",
36+
return res.status(200).json({
37+
message: "Task request returned successfully",
38+
data: data.taskRequestData,
4039
});
4140
} catch (err) {
4241
logger.error("Error while fetching task requests", err);

test/integration/taskRequests.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,8 @@ describe("Task Requests", function () {
157157
});
158158

159159
it("should return 404 if the resource is not found", function (done) {
160+
sinon.stub(taskRequestsModel, "fetchTaskRequestById").callsFake(() => []);
161+
160162
chai
161163
.request(app)
162164
.get(`/taskRequests/taskRequestId`)

0 commit comments

Comments
 (0)