[feature/new-members] updated code as per new roles property change

Author: rajakvk

controllers/members.js

@@ -33,7 +33,7 @@ const getIdleMembers = async (req, res) => {
   try {
     const allMembers = await memberQuery.fetchMembers()
     const taskParticipants = await tasks.fetchActiveTaskMembers()
-    const idleMembers = allMembers?.filter(({ id }) => !taskParticipants.has(id))
+    const idleMembers = allMembers.oldMembers?.filter(({ id }) => !taskParticipants.has(id))
     const idleMemberUserNames = idleMembers?.map((member) => member.username)
 
     return res.json({

models/members.js

@@ -28,9 +28,9 @@ const fetchMembers = async () => {
           email: undefined
         }
         if (memberData.roles && memberData.roles.member) {
-          allMembers.newMembers.push(curatedMemberData)
-        } else {
           allMembers.oldMembers.push(curatedMemberData)
+        } else {
+          allMembers.newMembers.push(curatedMemberData)
         }
       })
     }

test/fixtures/user/user.js

@@ -22,7 +22,7 @@ module.exports = () => {
       phone: '1234567890',
       email: '[email protected]',
       roles: {
-        admin: true
+        member: true
       },
       tokens: {
         githubAccessToken: 'githubAccessToken'

test/integration/members.test.js

@@ -47,7 +47,7 @@ describe('Members', function () {
           expect(res.body.message).to.equal('Members returned successfully!')
           expect(res.body.members.newMembers).to.be.a('array')
           expect(res.body.members.oldMembers).to.be.a('array')
-          expect(res.body.members.oldMembers[0].roles.admin).to.eql(true)
+          expect(res.body.members.oldMembers[0].roles.member).to.eql(true)
 
           return done()
         })