Skip to content

Commit eec7bf0

Browse files
authored
Merge pull request #1317 from Real-Dev-Squad/feat/remove-skip-from-tests
removes the skip from the tests
2 parents f3b50a9 + 5f05ae3 commit eec7bf0

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

test/integration/taskBasedStatusUpdate.test.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,7 @@ describe("Task Based Status Updates", function () {
331331
await cleanDb();
332332
});
333333

334-
// eslint-disable-next-line mocha/no-skipped-tests
335-
it.skip("should return the correct results when there are no errors", async function () {
334+
it("should return the correct results when there are no errors", async function () {
336335
const res = await chai
337336
.request(app)
338337
.patch(`/users/status/batch`)
@@ -387,8 +386,7 @@ describe("Task Based Status Updates", function () {
387386
expect(userStatus009Data.currentStatus.state).to.equal(userState.ACTIVE);
388387
});
389388

390-
// eslint-disable-next-line mocha/no-skipped-tests
391-
it.skip("should throw an error if users firestore batch operations fail", async function () {
389+
it("should throw an error if users firestore batch operations fail", async function () {
392390
sinon.stub(firestore, "batch").throws(new Error("something went wrong"));
393391

394392
const res = await chai
@@ -463,8 +461,7 @@ describe("Task Based Status Updates", function () {
463461
]);
464462
});
465463

466-
// eslint-disable-next-line mocha/no-skipped-tests
467-
it.skip("should throw an error when an error occurs", async function () {
464+
it("should throw an error when an error occurs", async function () {
468465
sinon
469466
.stub(userStatusModelFunction, "getTaskBasedUsersStatus")
470467
.throws(
@@ -474,7 +471,7 @@ describe("Task Based Status Updates", function () {
474471
);
475472
const response = await chai
476473
.request(app)
477-
.get(`/users/status?batch=true`)
474+
.get(`/users/status?aggregate=true`)
478475
.set("cookie", `${cookieName}=${superUserJwt}`);
479476
expect(response.status).to.equal(500);
480477
expect(response.body.message).to.equal(

test/unit/middlewares/userStatusValidator.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ const { validateGetQueryParams } = require("../../../middlewares/validators/user
44

55
describe("Middleware | Validators | userStatus", function () {
66
describe("validateRequestQuery", function () {
7-
// eslint-disable-next-line mocha/no-skipped-tests
8-
it.skip("lets the request pass to the next function for a valid query", async function () {
7+
it("lets the request pass to the next function for a valid query", async function () {
98
const res = {};
109
const req = {
1110
query: {
@@ -17,7 +16,7 @@ describe("Middleware | Validators | userStatus", function () {
1716
expect(nextSpy.calledOnce).to.be.equal(true);
1817

1918
delete req.query.state;
20-
req.query.batch = true;
19+
req.query.aggregate = true;
2120
await validateGetQueryParams(req, res, nextSpy);
2221
expect(nextSpy.calledTwice).to.be.equal(true);
2322
});

test/unit/utils/userStatusValidator.test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ const { validateMassUpdate } = require("../../../middlewares/validators/userStat
44

55
describe("Middleware | Validators | massUpdateUserStatus", function () {
66
describe("validateMassUpdate", function () {
7-
// eslint-disable-next-line mocha/no-skipped-tests
8-
it.skip("lets the request pass to the next function for a valid query", async function () {
7+
it("lets the request pass to the next function for a valid query", async function () {
98
const res = {};
109
const req = {
1110
body: {

0 commit comments

Comments
 (0)