fix empty search term case (#1369)

Author: vinit717

controllers/tasks.js

@@ -142,6 +142,12 @@ const fetchTasks = async (req, res) => {
 
     if (queryString !== undefined) {
       const searchParams = parseSearchQuery(queryString);
+      if (!searchParams.searchTerm) {
+        return res.status(404).json({
+          message: "No tasks found.",
+          tasks: [],
+        });
+      }
       const filterTasks = await tasks.fetchTasks(searchParams.searchTerm);
       const tasksWithRdsAssigneeInfo = await fetchTasksWithRdsAssigneeInfo(filterTasks);
       if (tasksWithRdsAssigneeInfo.length === 0) {

test/integration/tasks.test.js

@@ -293,6 +293,23 @@ describe("Tasks", function () {
             return done(err);
           }
 
+          expect(res).to.have.status(404);
+          expect(res.body).to.be.a("object");
+          expect(res.body.message).to.equal("No tasks found.");
+          expect(res.body.tasks).to.be.a("array");
+          expect(res.body.tasks).to.have.lengthOf(0);
+          return done();
+        });
+    });
+    it("Should return no task found when there is no searchterm", function (done) {
+      chai
+        .request(app)
+        .get(`/tasks?q=searchTerm:`)
+        .end((err, res) => {
+          if (err) {
+            return done(err);
+          }
+
           expect(res).to.have.status(404);
           expect(res.body).to.be.a("object");
           expect(res.body.message).to.equal("No tasks found.");