Update: added test cases for internal server error

Author: gauravsinhaweb

controllers/members.js

@@ -1,7 +1,7 @@
 const ROLES = require("../constants/roles");
 const members = require("../models/members");
 const tasks = require("../models/tasks");
-const { SOMETHING_WENT_WRONG } = require("../constants/errorMessages");
+const { SOMETHING_WENT_WRONG, INTERNAL_SERVER_ERROR } = require("../constants/errorMessages");
 const dataAccess = require("../services/dataAccessLayer");
 const { addLog } = require("../models/logs");
 /**
@@ -99,13 +99,13 @@ const archiveMembers = async (req, res) => {
       if (successObject.isArchived) {
         return res.boom.badRequest("User is already archived");
       }
-      addLog("archiveDetails", meta, { body: body?.reason });
+      addLog("archive-details", meta, { body: body?.reason });
       return res.status(204).send();
     }
     return res.boom.notFound("User doesn't exist");
   } catch (err) {
     logger.error(`Error while retriving contributions ${err}`);
-    return res.boom.badImplementation(SOMETHING_WENT_WRONG);
+    return res.status(500).json({ message: INTERNAL_SERVER_ERROR });
   }
 };
 

models/logs.js

@@ -3,6 +3,7 @@ const { getBeforeHourTime } = require("../utils/time");
 const logsModel = firestore.collection("logs");
 const admin = require("firebase-admin");
 const { logType } = require("../constants/logs");
+const { INTERNAL_SERVER_ERROR } = require("../constants/errorMessages");
 
 /**
  * Adds log
@@ -22,7 +23,7 @@ const addLog = async (type, meta, body) => {
     return await logsModel.add(log);
   } catch (err) {
     logger.error("Error in adding log", err);
-    throw err;
+    throw new Error(INTERNAL_SERVER_ERROR);
   }
 };
 
@@ -77,7 +78,7 @@ const fetchLogs = async (query, param) => {
     return logs;
   } catch (err) {
     logger.error("Error in adding log", err);
-    throw err;
+    throw new Error(INTERNAL_SERVER_ERROR);
   }
 };
 

test/fixtures/logs/archievedUsers.js

@@ -1,6 +1,6 @@
 const archivedUserDetailsModal = [
   {
-    type: "archivedUsers",
+    type: "archive-details",
     meta: {
       userId: "TEST_USER_ID_1",
       superUserId: "TEST_SUPER_USER_ID",
@@ -15,7 +15,7 @@ const archivedUserDetailsModal = [
     },
   },
   {
-    type: "archivedUsers",
+    type: "archive-details",
     meta: {
       userId: "TEST_USER_ID_2",
       superUserId: "TEST_SUPER_USER_ID",
@@ -30,7 +30,7 @@ const archivedUserDetailsModal = [
     },
   },
   {
-    type: "archivedUsers",
+    type: "archive-details",
     meta: {
       userId: "TEST_USER_ID_1",
       superUserId: "TEST_SUPER_USER_ID",

test/integration/members.test.js

@@ -12,6 +12,9 @@ const userData = require("../fixtures/user/user")();
 
 const config = require("config");
 const cookieName = config.get("userToken.cookieName");
+const Sinon = require("sinon");
+const { INTERNAL_SERVER_ERROR } = require("../../constants/errorMessages");
+const dataAccess = require("../.././services/dataAccessLayer");
 
 chai.use(chaiHttp);
 
@@ -258,11 +261,34 @@ describe("Members", function () {
   });
 
   describe("PATCH /members/archiveMembers/:username", function () {
+    let dataAccessStub;
     beforeEach(async function () {
       const superUserId = await addUser(superUser);
       jwt = authService.generateAuthToken({ userId: superUserId });
     });
-
+    afterEach(async function () {
+      Sinon.restore();
+      await cleanDb();
+    });
+    it("Should return an object with status 500 and an error message", function (done) {
+      dataAccessStub = Sinon.stub(dataAccess, "retrieveUsers");
+      dataAccessStub.throws(new Error(INTERNAL_SERVER_ERROR));
+      addUser(userToBeArchived).then(() => {
+        chai
+          .request(app)
+          .patch(`/members/archiveMembers/${userToBeArchived.username}`)
+          .set("Cookie", `${cookieName}=${jwt}`)
+          .send({ reason: "some reason" })
+          .end((err, res) => {
+            if (err) {
+              return done(err);
+            }
+            expect(res).to.have.status(500);
+            expect(res.body.message).to.be.equal(INTERNAL_SERVER_ERROR);
+            return done();
+          });
+      });
+    });
     it("Should return 404 if user doesn't exist", function (done) {
       chai
         .request(app)
@@ -279,7 +305,24 @@ describe("Members", function () {
           return done();
         });
     });
+    it("Should return 400 if body is empty", function (done) {
+      chai
+        .request(app)
+        .patch(`/members/archiveMembers/${userToBeArchived.username}`)
+        .set("cookie", `${cookieName}=${jwt}`)
+        .send({})
+        .end((err, res) => {
+          if (err) {
+            return done(err);
+          }
+
+          expect(res).to.have.status(400);
+          expect(res.body).to.be.a("object");
+          expect(res.body.message).to.equal("Reason is required");
 
+          return done();
+        });
+    });
     it("Should archive the user", function (done) {
       addUser(userToBeArchived).then(() => {
         chai
@@ -321,26 +364,5 @@ describe("Members", function () {
           });
       });
     });
-
-    it("Should return 401 if user is not a super user", function (done) {
-      addUser(nonSuperUser).then((nonSuperUserId) => {
-        const nonSuperUserJwt = authService.generateAuthToken({ userId: nonSuperUserId });
-        chai
-          .request(app)
-          .patch(`/members/moveToMembers/${nonSuperUser.username}`)
-          .set("cookie", `${cookieName}=${nonSuperUserJwt}`)
-          .end((err, res) => {
-            if (err) {
-              return done(err);
-            }
-
-            expect(res).to.have.status(401);
-            expect(res.body).to.be.a("object");
-            expect(res.body.message).to.equal("You are not authorized for this action.");
-
-            return done();
-          });
-      });
-    });
   });
 });

test/unit/models/logs.test.js

@@ -6,6 +6,15 @@ const logsQuery = require("../../../models/logs");
 const cacheData = require("../../fixtures/cloudflareCache/data");
 const logsData = require("../../fixtures/logs/archievedUsers");
 const app = require("../../../server");
+const Sinon = require("sinon");
+const { INTERNAL_SERVER_ERROR } = require("../../../constants/errorMessages");
+const userData = require("../../fixtures/user/user")();
+const addUser = require("../../utils/addUser");
+const cookieName = config.get("userToken.cookieName");
+const authService = require("../../../services/authService");
+
+const superUser = userData[4];
+const userToBeMadeMember = userData[1];
 
 describe("Logs", function () {
   after(async function () {
@@ -40,7 +49,30 @@ describe("Logs", function () {
     });
   });
 
-  describe("GET /logs/archivedUsers", function () {
+  describe("GET /logs/archive-details", function () {
+    let addLogsStub;
+    let jwt;
+    beforeEach(async function () {
+      const superUserId = await addUser(superUser);
+      jwt = authService.generateAuthToken({ userId: superUserId });
+      await cleanDb();
+    });
+    afterEach(function () {
+      Sinon.restore();
+    });
+
+    it("Should return an object with status 500 and an error message", async function () {
+      addLogsStub = Sinon.stub(logsQuery, "fetchLogs");
+      addLogsStub.throws(new Error(INTERNAL_SERVER_ERROR));
+
+      addUser(userToBeMadeMember).then(() => {
+        const res = chai.request(app).get("/logs/archive-details").set("cookie", `${cookieName}=${jwt}`).send();
+
+        // expect(res).to.have.status(500);
+        // expect(res.body).to.have.property("message").that.is.a("string");
+        expect(res.body.message).to.equal(INTERNAL_SERVER_ERROR);
+      });
+    });
     it("Should return empty array if no logs found", async function () {
       const { type } = logsData.archivedUserDetailsModal[0];
       const query = {};