chore: remove feature flag onboarding extension (#2382)

* fix: remove feature flag from onboarding extension request features

* test: update tests after removing feature flag from onboarding extension

Author: mbramani

controllers/onboardingExtension.ts

@@ -151,10 +151,6 @@ export const updateOnboardingExtensionRequestState = async (
     req: UpdateOnboardingExtensionStateRequest, 
     res: OnboardingExtensionResponse )
     : Promise<OnboardingExtensionResponse> => {
-    
-    const dev = req.query.dev === "true";
-    
-    if(!dev) return res.boom.notImplemented("Feature not implemented");
 
     const body = req.body as UpdateOnboardingExtensionStateRequestBody;
     const lastModifiedBy = req?.userData?.id;
@@ -224,9 +220,6 @@ export const updateOnboardingExtensionRequestController = async (
     const id = req.params.id;
     const lastModifiedBy = req?.userData?.id;
     const isSuperuser = req?.userData?.roles?.super_user === true;
-    const dev = req.query.dev === "true";
-
-    if(!dev) return res.boom.notImplemented("Feature not implemented");
 
     try{
         const extensionRequestDoc = await requestModel.doc(id).get();

middlewares/skipAuthenticateForOnboardingExtension.ts

@@ -14,17 +14,11 @@ import { REQUEST_TYPE } from "../constants/requests";
 export const skipAuthenticateForOnboardingExtensionRequest = (authenticate, verifyDiscordBot) => {
     return async (req: Request, res: Response, next: NextFunction) => {
         const type = req.body.type;
-        const dev = req.query.dev;
 
         if(type === REQUEST_TYPE.ONBOARDING){
-            if (dev != "true"){
-                return res.status(501).json({
-                    message: "Feature not implemented"
-                })
-            }
             return await verifyDiscordBot(req, res, next);
         }
 
         return await authenticate(req, res, next)
     }
-}
+}

test/integration/onboardingExtension.test.ts

@@ -75,7 +75,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should not call verifyDiscordBot and return 401 response when extension type is not onboarding", (done)=> {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .send({...body, type: REQUEST_TYPE.OOO})
             .end((err, res)=>{
                 if(err) return done(err);
@@ -86,22 +86,10 @@ describe("/requests Onboarding Extension", () => {
             })
         })
 
-        it("should return Feature not implemented when dev is not true", (done) => {
-            chai.request(app)
-            .post(`${postEndpoint}`)
-            .send(body)
-            .end((err, res)=>{
-                if (err) return done(err);
-                expect(res.statusCode).to.equal(501);
-                expect(res.body.message).to.equal("Feature not implemented");
-                done();
-            })
-        })
-    
         it("should return Invalid Request when authorization header is missing", (done) => {
             chai
             .request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", "")
             .send(body)
             .end((err, res) => {
@@ -114,7 +102,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return Unauthorized Bot for invalid token", (done) => {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${BAD_TOKEN}`)
             .send(body)
             .end((err, res) => {
@@ -127,7 +115,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response for invalid value type of numberOfDays", (done) => {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send({...body, numberOfDays:"1"})
             .end((err, res) => {
@@ -141,7 +129,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response for invalid value of numberOfDays", (done) => {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send({...body, numberOfDays:1.4})
             .end((err, res) => {
@@ -155,7 +143,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response for invalid userId", (done) => {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send({...body, userId: undefined})
             .end((err, res) => {
@@ -172,7 +160,7 @@ describe("/requests Onboarding Extension", () => {
             sinon.stub(requestsQuery, "createRequest")
             .throws("Error while creating extension request");
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body)
             .end((err, res)=>{
@@ -186,7 +174,7 @@ describe("/requests Onboarding Extension", () => {
         it("should return 500 response when discordJoinedAt date string is invalid", (done) => {
             createUserStatusWithState(testUserIdForInvalidDiscordJoinedDate, userStatusModel, userState.ONBOARDING);
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send({...body, userId: testUserDiscordIdForInvalidDiscordJoinedDate})
             .end((err, res)=>{
@@ -199,7 +187,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 404 response when user does not exist", (done) => {
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send({...body, userId: "11111"})
             .end((err, res) => {
@@ -214,7 +202,7 @@ describe("/requests Onboarding Extension", () => {
         it("should return 403 response when user's status is not onboarding", (done)=> {
             createUserStatusWithState(testUserId, userStatusModel, userState.ACTIVE);
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body)
             .end((err, res) => {
@@ -231,7 +219,7 @@ describe("/requests Onboarding Extension", () => {
             requestsQuery.createRequest({...extensionRequest, state: REQUEST_STATE.PENDING, userId: testUserId});
 
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body)
             .end((err, res) => {
@@ -246,7 +234,7 @@ describe("/requests Onboarding Extension", () => {
         it("should return 201 for successful response when user has onboarding state", (done)=> {
             createUserStatusWithState(testUserId, userStatusModel, userState.ONBOARDING);
             chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body)
             .end((err, res) => {
@@ -271,7 +259,7 @@ describe("/requests Onboarding Extension", () => {
             });
 
             const res = await chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body);
 
@@ -296,7 +284,7 @@ describe("/requests Onboarding Extension", () => {
             });
 
             const res = await chai.request(app)
-            .post(`${postEndpoint}?dev=true`)
+            .post(postEndpoint)
             .set("authorization", `Bearer ${botToken}`)
             .send(body);
 
@@ -418,7 +406,7 @@ describe("/requests Onboarding Extension", () => {
                 type: REQUEST_TYPE.ONBOARDING, 
                 requestNumber: 2
             });
-            putEndpoint = `/requests/${latestExtension.id}?dev=true`;
+            putEndpoint = `/requests/${latestExtension.id}`;
             authToken = generateAuthToken({userId});
         })
 
@@ -443,7 +431,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return Invalid request type for incorrect value of type", (done) => {
             chai.request(app)
-            .put("/requests/1111?dev=true")
+            .put("/requests/1111")
             .set("authorization", `Bearer ${authToken}`)
             .send({...body, type: "<InvalidType>"})
             .end((err, res)=>{
@@ -455,19 +443,6 @@ describe("/requests Onboarding Extension", () => {
             })
         })
 
-        it("should return Feature not implemented when dev is not true", (done) => {
-            chai.request(app)
-            .put(`/requests/1111?dev=false`)
-            .send(body)
-            .set("authorization", `Bearer ${authToken}`)
-            .end((err, res)=>{
-                if (err) return done(err);
-                expect(res.statusCode).to.equal(501);
-                expect(res.body.message).to.equal("Feature not implemented");
-                done();
-            })
-        })
-
         it("should return Unauthenticated User when authorization header is missing", (done) => {
             chai.request(app)
             .put(putEndpoint)
@@ -510,7 +485,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 404 response for invalid extension id", (done) => {
             chai.request(app)
-            .put(`/requests/1111?dev=true`)
+            .put(`/requests/1111`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -538,7 +513,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response when extension state is approved", (done) => {
             chai.request(app)
-            .put(`/requests/${latestApprovedExtension.id}?dev=true`)
+            .put(`/requests/${latestApprovedExtension.id}`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -552,7 +527,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response when extension state is rejected", (done) => {
             chai.request(app)
-            .put(`/requests/${latestRejectedExtension.id}?dev=true`)
+            .put(`/requests/${latestRejectedExtension.id}`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -646,7 +621,7 @@ describe("/requests Onboarding Extension", () => {
                 userId: userId
             });
             oooRequest = await requestsQuery.createRequest({type: REQUEST_TYPE.OOO, userId: userId});
-            patchEndpoint = `/requests/${latestValidExtension.id}?dev=true`;
+            patchEndpoint = `/requests/${latestValidExtension.id}`;
             authToken = generateAuthToken({userId});
         })
 
@@ -669,19 +644,6 @@ describe("/requests Onboarding Extension", () => {
             })
         })
 
-        it("should return Feature not implemented when dev is not true", (done) => {
-            chai.request(app)
-            .patch(`/requests/1111?dev=false`)
-            .send(body)
-            .set("authorization", `Bearer ${authToken}`)
-            .end((err, res)=>{
-                if (err) return done(err);
-                expect(res.statusCode).to.equal(501);
-                expect(res.body.message).to.equal("Feature not implemented");
-                done();
-            })
-        })
-
         it("should return Unauthenticated User when authorization header is missing", (done) => {
             chai
             .request(app)
@@ -725,7 +687,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 404 response for invalid extension id", (done) => {
             chai.request(app)
-            .patch(`/requests/1111?dev=true`)
+            .patch(`/requests/1111`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -753,7 +715,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response when request type is not onboarding", (done) => {
             chai.request(app)
-            .patch(`/requests/${oooRequest.id}?dev=true`)
+            .patch(`/requests/${oooRequest.id}`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -767,7 +729,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response when extension state is not pending", (done) => {
             chai.request(app)
-            .patch(`/requests/${latestApprovedExtension.id}?dev=true`)
+            .patch(`/requests/${latestApprovedExtension.id}`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
@@ -781,7 +743,7 @@ describe("/requests Onboarding Extension", () => {
 
         it("should return 400 response when old dealdine is greater than new deadline", (done) => {
             chai.request(app)
-            .patch(`/requests/${latestInvalidExtension.id}?dev=true`)
+            .patch(`/requests/${latestInvalidExtension.id}`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {

test/unit/middlewares/skipAuthenticateForOnboardingExtension.test.ts

@@ -25,23 +25,12 @@ describe("skipAuthenticateForOnboardingExtensionRequest Middleware", () => {
         assert.isTrue(verifyDiscordBot.notCalled, "verifyDiscordBot should not be called");
     });
 
-    it("should not call verifyDicordBot and authenticate when dev is not true and type is onboarding", async () => {
-        req.query.dev = "false";
-        req.body.type = REQUEST_TYPE.ONBOARDING;
-
-        middleware(req, res, next);
-
-        assert.isTrue(verifyDiscordBot.notCalled, "verifyDiscordBot should not be called");
-        assert.isTrue(authenticate.notCalled, "authenticate should not be called");
-    });
-
-    it("should call verifyDiscordBot when dev is true and type is onboarding", () => {
-        req.query.dev = "true";
+    it("should call verifyDiscordBot when type is onboarding", async () => {
         req.body.type = REQUEST_TYPE.ONBOARDING;
 
         middleware(req, res, next);
 
         assert.isTrue(verifyDiscordBot.calledOnce, "verifyDiscordBot should be called once");
         assert.isTrue(authenticate.notCalled, "authenticate should not be called");
     });
-});
+});