Removes validation for user status in task requests (#1626)

Author: Ajeyakrishna-k

middlewares/taskRequests.js

@@ -1,6 +1,4 @@
 const { SOMETHING_WENT_WRONG } = require("../constants/errorMessages");
-const { userState } = require("../constants/userStatus");
-const userStatusModel = require("../models/userStatus.js");
 const dataAccess = require("../services/dataAccessLayer");
 /**
  * Validates user id for task request
@@ -20,14 +18,6 @@ async function validateUser(req, res, next) {
       return res.boom.conflict("User does not exist");
     }
 
-    const { userStatusExists, data: userStatus } = await userStatusModel.getUserStatus(userId);
-    if (!userStatusExists) {
-      return res.boom.conflict("User status does not exist");
-    }
-    if (userStatus.currentStatus.state === userState.ACTIVE) {
-      return res.boom.conflict("User is currently active on another task");
-    }
-
     req.body.user = user;
 
     return next();

test/integration/taskRequests.test.js

@@ -374,26 +374,6 @@ describe("Task Requests", function () {
 
         taskId = (await tasksModel.updateTask(taskData[4])).taskId;
       });
-
-      it("should match response", function (done) {
-        chai
-          .request(app)
-          .post("/taskRequests/addOrUpdate")
-          .set("cookie", `${cookieName}=${jwt}`)
-          .send({
-            taskId,
-            userId,
-          })
-          .end((err, res) => {
-            if (err) {
-              return done(err);
-            }
-
-            expect(res).to.have.status(409);
-            expect(res.body.message).to.equal("User status does not exist");
-            return done();
-          });
-      });
     });
 
     describe("When the user status is not idle", function () {
@@ -404,29 +384,6 @@ describe("Task Requests", function () {
 
         taskId = (await tasksModel.updateTask(taskData[4])).taskId;
       });
-      it("should match response when the user is active on another task", function (done) {
-        sinon
-          .stub(userStatusModel, "getUserStatus")
-          .callsFake(() => ({ userStatusExists: true, data: activeUserStatus }));
-
-        chai
-          .request(app)
-          .post("/taskRequests/addOrUpdate")
-          .set("cookie", `${cookieName}=${jwt}`)
-          .send({
-            taskId,
-            userId,
-          })
-          .end((err, res) => {
-            if (err) {
-              return done(err);
-            }
-
-            expect(res).to.have.status(409);
-            expect(res.body.message).to.equal("User is currently active on another task");
-            return done();
-          });
-      });
     });
   });
 
@@ -472,26 +429,6 @@ describe("Task Requests", function () {
           });
       });
 
-      it("should return 409 error with message when user is active", function (done) {
-        chai
-          .request(app)
-          .patch("/taskRequests/approve")
-          .set("cookie", `${cookieName}=${jwt}`)
-          .send({
-            taskRequestId: taskId,
-            userId: activeUserId,
-          })
-          .end((err, res) => {
-            if (err) {
-              return done(err);
-            }
-
-            expect(res).to.have.status(409);
-            expect(res.body.message).to.equal("User is currently active on another task");
-            return done();
-          });
-      });
-
       it("should throw 400 error when taskRequestId is missing", function (done) {
         chai
           .request(app)