fix: improve error handling in acknowledgeOooRequest function

tejaskh3 · tejaskh3 · commit fec48b13c7a5 · 2025-07-19T21:37:02.000+05:30
diff --git a/controllers/oooRequests.ts b/controllers/oooRequests.ts
@@ -192,7 +192,6 @@ export const acknowledgeOooRequest = async (
     }
     catch(error){
       logger.error(ERROR_WHILE_ACKNOWLEDGING_REQUEST, error);
-      next(error);
-      return res;
+      return res.boom.badImplementation(ERROR_WHILE_ACKNOWLEDGING_REQUEST);
   }
 };
diff --git a/types/oooRequest.d.ts b/types/oooRequest.d.ts
@@ -41,7 +41,7 @@ export type OooRequestCreateRequest = Request & {
   query: RequestQuery;
 };
 
-export type OooRequestUpdateRequest = Request & { oooRequestUpdateBody , userData: userData , query: RequestQuery , params: RequestParams };
+
 
 export type AcknowledgeOooRequestQuery = RequestQuery & {
   dev?: string

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,6 @@ export const acknowledgeOooRequest = async (`
`192`	`192`	`}`
`193`	`193`	`catch(error){`
`194`	`194`	`logger.error(ERROR_WHILE_ACKNOWLEDGING_REQUEST, error);`
`195`		`- next(error);`
`196`		`- return res;`
	`195`	`+ return res.boom.badImplementation(ERROR_WHILE_ACKNOWLEDGING_REQUEST);`
`197`	`196`	`}`
`198`	`197`	`};`