Feat: Implement API for Tracking Orphaned Tasks #2252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tasks/orphaned-tasks retrieves tasks assigned to departed users Added test cases for the API and fixed test case issues arising from mock data additions used in current API testing.
Closed
10 tasks
… and the corresponding queries to model. - removed test cases from integration testing and moved it to unit testing. - moved updateTaskStatusToDone to tasks model as it was causing circular dependency. - created a separate fixture file for mock data required to test the feature. - reverted the test case changes done for other test cases due to mock data changes.
VinuB-Dev
force-pushed
the
feat/orphaned-tasks-api
branch
from
cfb3fb0 to
b4415d9
Compare
- Added function documentation for all the modified and new model functions. - Implemented a negative unit test case for the `fetchUsersNotInDiscordServer` function. - Updated `fetchUsersNotInDiscordServer` to use `userId` as a parameter instead of the entire `user` object. - Added test cases for recent model changes.
…the /tasks/orphaned-tasks API. - Implemented negative test cases for the /tasks/orphaned-tasks endpoint: - Tested the scenario where the dev flag is not provided, expecting a 404 status code with a "Route not found" message. - Tested the scenario where the database query fails, ensuring the API responds with a 500 status code and an appropriate error message.
pankajjs
approved these changes
Nov 19, 2024
… /tasks?orphaned=true route. Modifications in code and tests related to the same.
pankajjs
reviewed
Nov 25, 2024
Comment on lines
+139
to
+150
| status, | ||
| page, | ||
| size, | ||
| prev, | ||
| next, | ||
| q: queryString, | ||
| assignee, | ||
| title, | ||
| userFeatureFlag, | ||
| orphaned, | ||
| dev, | ||
| } = req.query; |
There was a problem hiding this comment.
Are we using all these query?
There was a problem hiding this comment.
yeah I only added orphaned and dev, it's prettier change.
|
Splitting this PR into smaller parts for easier review. This PR will serve as the main split: #2267. Closing this PR as part of the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 15/11/2024
Developer Name: Vignesh B S
Issue Ticket Number
Closes Real-Dev-Squad/website-dashboard#888
Description
Implemented changes in tasks api for Tracking Orphaned Tasks
tasks?orphaned=true- Retrieves tasks assigned to users who have departed the Discord server.Added test cases for the above api.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
PRD
Design Doc
Have moved the updateTaskStatusToDone function to models as it was directly interacts with the database and performing operations such as updating task documents. This was also causing circular dependency issues.