Skip to content

Commit 3cae702

Browse files
Remove task-requests dev flag (#656)
* chore: remove dev flag for task-requests * chore: remove dev flag from api call * chore: add api dev flag back * Removes dev flag from fetch task requests api (#657) chore: removes task-requests-api-dev-flag
1 parent 3da4fad commit 3cae702

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

__tests__/home/home.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,13 @@ describe('Home Page', () => {
186186
expect(syncExternalAccountsUpdate).toBeTruthy();
187187
});
188188
it('should display the task requests button', async () => {
189-
await page.goto('http://localhost:8000/?dev=true');
189+
await page.goto('http://localhost:8000');
190190
await page.waitForNetworkIdle();
191191
const taskRequestsButton = await page.$('#task-requests-link');
192192
expect(taskRequestsButton).toBeTruthy();
193193
});
194194
it('should go to the task requests page', async () => {
195-
await page.goto('http://localhost:8000/?dev=true');
195+
await page.goto('http://localhost:8000');
196196
await page.waitForNetworkIdle();
197197

198198
const taskRequestsButton = await page.$('#task-requests-link');

__tests__/task-requests/task-request.test.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,8 @@ describe('Task Requests', () => {
2828
page.on('request', (request) => {
2929
if (
3030
request.url() === `${API_BASE_URL}/taskRequests` ||
31-
request.url() === `${API_BASE_URL}/taskRequests?dev=true` ||
3231
request.url() ===
33-
`${API_BASE_URL}/taskRequests?size=20&q=status%3Apending+sort%3Acreated-asc&dev=true`
32+
`${API_BASE_URL}/taskRequests?size=20&q=status%3Apending+sort%3Acreated-asc`
3433
) {
3534
request.respond({
3635
status: 200,
@@ -44,7 +43,7 @@ describe('Task Requests', () => {
4443
});
4544
} else if (
4645
request.url() ===
47-
`${API_BASE_URL}/taskRequests?size=20&q=status%3Aapproved++sort%3Acreated-asc&dev=true`
46+
`${API_BASE_URL}/taskRequests?size=20&q=status%3Aapproved++sort%3Acreated-asc`
4847
) {
4948
const list = [];
5049
for (let i = 0; i < 20; i++) {
@@ -55,7 +54,7 @@ describe('Task Requests', () => {
5554
contentType: 'application/json',
5655
body: JSON.stringify({
5756
data: list,
58-
next: '/taskRequests?size=20&q=status%3Aapproved++sort%3Acreated-asc&dev=true',
57+
next: '/taskRequests?size=20&q=status%3Aapproved++sort%3Acreated-asc',
5958
}),
6059
});
6160
} else {

script.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ const syncIdle7dUsersUpdate = document.getElementById(
1919
);
2020
const repoSyncStatusUpdate = document.getElementById(SYNC_REPO_STATUS_UPDATE);
2121
const params = new URLSearchParams(window.location.search);
22-
const taskRequestsLink =
23-
params.get('dev') === 'true' && document.getElementById(TASK_REQUESTS_LINK);
22+
const taskRequestsLink = document.getElementById(TASK_REQUESTS_LINK);
2423

2524
const syncNicknamesStatusUpdate = document.getElementById(
2625
SYNC_NICKNAMES_STATUS_UPDATE,

task-requests/script.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ let isDataLoading = false;
2121
let selectedSortButton = null;
2222

2323
const filterStates = {
24-
dev: true,
2524
status: Status.PENDING,
2625
order: CREATED_TIME,
2726
size: DEFAULT_PAGE_SIZE,

0 commit comments

Comments
 (0)