Discord groups bug fixes (#764)

bug fixes
Profile loading showing with login button
Add me and Remove Me not working in production
Handle render function deleting non existing element case

Author: pallabez

groups/render.js

@@ -48,6 +48,8 @@ const renderNavbarProfileSignin = () => {
 const removeLoadingNavbarProfile = () => {
   const profileEl = document.querySelector('.navbar__profile');
   const profileLoadingEl = profileEl.querySelector('.profile--loading');
+
+  if (!profileLoadingEl) return;
   profileEl.removeChild(profileLoadingEl);
 };
 

groups/script.js

@@ -140,6 +140,7 @@ const onCreate = () => {
       console.error(err);
     })
     .finally(() => {
+      removeLoadingNavbarProfile();
       removeLoadingCards();
     });
 
@@ -246,7 +247,7 @@ function renderAllGroups({ cardOnClick }) {
   dataStore.filteredGroupsIds.forEach((id) =>
     renderGroupById({
       group: dataStore.groups[id],
-      cardOnClick,
+      cardOnClick: () => cardOnClick(id),
     }),
   );
 }