Skip to content

Commit 6945263

Browse files
authored
fix standup page (#805)
1 parent a3047b4 commit 6945263

File tree

2 files changed

+27
-21
lines changed

2 files changed

+27
-21
lines changed

standup/script.js

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ function processStandupData(standupItems) {
109109
}
110110

111111
function createTableHeaderElement() {
112-
const tableHeaderElement = createElement({
112+
const tableHeaderElement = createStandupElement({
113113
type: 'thead',
114114
classList: ['table-header'],
115115
});
116-
const headerRowElement = createElement({
116+
const headerRowElement = createStandupElement({
117117
type: 'tr',
118118
classList: ['table-header'],
119119
});
120-
const headerCellElement = createElement({
120+
const headerCellElement = createStandupElement({
121121
type: 'th',
122122
classList: ['user', 'date', 'table-head'],
123123
});
@@ -129,7 +129,7 @@ function createTableHeaderElement() {
129129
date = new Date(date.getTime() - oneDay)
130130
) {
131131
if (!isSunday(date)) {
132-
const dateCellElement = createElement({
132+
const dateCellElement = createStandupElement({
133133
type: 'th',
134134
classList: ['dates'],
135135
scope: 'row',
@@ -159,20 +159,26 @@ function createTableHeaderElement() {
159159
}
160160

161161
function createTableRowElement({ userName, imageUrl, userStandupData }) {
162-
const rowElement = createElement({ type: 'tr', classList: ['table-row'] });
163-
const userCellElement = createElement({ type: 'td', classList: ['user'] });
162+
const rowElement = createStandupElement({
163+
type: 'tr',
164+
classList: ['table-row'],
165+
});
166+
const userCellElement = createStandupElement({
167+
type: 'td',
168+
classList: ['user'],
169+
});
164170
userCellElement.scope = 'row';
165-
const userContainerElement = createElement({
171+
const userContainerElement = createStandupElement({
166172
type: 'div',
167173
classList: ['user-list-item'],
168174
});
169-
const userImageElement = createElement({
175+
const userImageElement = createStandupElement({
170176
type: 'img',
171177
classList: ['user-image'],
172178
});
173179
userImageElement.src = imageUrl || dummyPicture;
174180
userImageElement.alt = userName;
175-
const userNameElement = createElement({
181+
const userNameElement = createStandupElement({
176182
type: 'p',
177183
classList: ['user-name'],
178184
});
@@ -190,31 +196,31 @@ function createTableRowElement({ userName, imageUrl, userStandupData }) {
190196
const month = userStandupData.month;
191197
const year = userStandupData.year;
192198
for (let i = 0; i < standupStatus.length; i++) {
193-
const statusCellElement = createElement({
199+
const statusCellElement = createStandupElement({
194200
type: 'td',
195201
classList: ['status'],
196202
});
197203
statusCellElement.textContent = standupStatus[i];
198-
const tooltipElement = createElement({
204+
const tooltipElement = createStandupElement({
199205
type: 'div',
200206
classList: ['tooltiptext'],
201207
style: {
202208
visibility: 'visible',
203209
},
204210
});
205-
const completedTextElement = createElement({
211+
const completedTextElement = createStandupElement({
206212
type: 'p',
207213
classList: ['today-standup', 'tooltip-text'],
208214
});
209-
const yesterdayStandupElement = createElement({
215+
const yesterdayStandupElement = createStandupElement({
210216
type: 'p',
211217
classList: ['yesterday-standup', 'tooltip-text'],
212218
});
213-
const blockersElement = createElement({
219+
const blockersElement = createStandupElement({
214220
type: 'p',
215221
classList: ['blockers', 'tooltip-text'],
216222
});
217-
const noStandupTextElement = createElement({
223+
const noStandupTextElement = createStandupElement({
218224
type: 'p',
219225
classList: ['no-standup-text'],
220226
});

standup/utils.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ async function makeApiCall(url, method, body, credentials, headers, options) {
1414
}
1515
}
1616

17-
function createElement({ type, classList }) {
17+
function createStandupElement({ type, classList }) {
1818
const element = document.createElement(type);
1919
element.classList.add(...classList);
2020
return element;
@@ -46,25 +46,25 @@ function createSidebarPanelElement(
4646
currentMonthName,
4747
currentYear,
4848
) {
49-
const standupHeadElement = createElement({
49+
const standupHeadElement = createStandupElement({
5050
type: 'h4',
5151
classList: ['standup-head'],
5252
});
5353
standupHeadElement.innerHTML = `Standup for ${day} ${currentMonthName} ${currentYear}`;
54-
const sidebarPanelElement = createElement({
54+
const sidebarPanelElement = createStandupElement({
5555
type: 'div',
5656
classList: ['sidebar-panel', 'sidebar'],
5757
});
5858
sidebarPanelElement.id = 'standupSidebar';
59-
const completedElement = createElement({
59+
const completedElement = createStandupElement({
6060
type: 'div',
6161
classList: ['completed'],
6262
});
63-
const plannedElement = createElement({
63+
const plannedElement = createStandupElement({
6464
type: 'div',
6565
classList: ['planned'],
6666
});
67-
const blockersElement = createElement({
67+
const blockersElement = createStandupElement({
6868
type: 'div',
6969
classList: ['blockers'],
7070
});

0 commit comments

Comments
 (0)