Fix: selected filters badge deletion when x icon is clicked in task-requests page (#717)

* fix deleteBadge function

* test: add test case for badge deletion via icon click

Author: VinayakaHegade

__tests__/task-requests/task-request.test.js

@@ -517,4 +517,19 @@ describe('badges', () => {
     badges = await page.$$('.badge');
     expect(badges.length).toBe(0);
   });
+
+  it('verifies that badge is removed when delete icon is clicked', async () => {
+    await page.goto(
+      `${SITE_URL}/task-requests/?sort=created-asc&status=denied&dev=true`,
+    );
+
+    let badgeTexts = await getBadgeTexts(page);
+    expect(badgeTexts).toContain('denied');
+
+    const deniedBadgeDeleteIcon = await page.$('.badge__delete');
+    await deniedBadgeDeleteIcon.click();
+
+    badgeTexts = await getBadgeTexts(page);
+    expect(badgeTexts).not.toContain('denied');
+  });
 });

task-requests/script.js

@@ -138,8 +138,11 @@ function handleBadgeDeletion(badgeType, badgeContent) {
 }
 
 function deleteBadge(e, badgeType) {
-  const badgeContent = e.target.textContent;
-  handleBadgeDeletion(badgeType, badgeContent);
+  const badge = e.target.closest('.badge');
+  if (badge) {
+    const badgeContent = badge.querySelector('.badge__name').textContent;
+    handleBadgeDeletion(badgeType, badgeContent);
+  }
 }
 
 function showBadges() {