Skip to content

Commit 9bab0f5

Browse files
authored
Merge pull request #761 from Real-Dev-Squad/develop
Dev to Main Sync
2 parents 6a8768a + 16d4f1b commit 9bab0f5

File tree

4 files changed

+26
-14
lines changed

4 files changed

+26
-14
lines changed

__tests__/extension-requests/extension-requests.test.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -663,18 +663,21 @@ describe('Tests the Extension Requests Screen', () => {
663663
expect(extensionCardsAfter.length).toBe(4);
664664
});
665665

666-
it('Checks whether the timestamp are sorted', async () => {
666+
it('Checks whether the timestamps are sorted', async () => {
667667
const extensionCards = await page.$$('.extension-card');
668668

669669
const requestDaysArray = [];
670670
for (const card of extensionCards) {
671671
const requestedDays = await card.$eval(
672672
'.requested-day > .tooltip',
673-
(requestDays) => requestDays.textContent,
673+
(requestDays) => new Date(requestDays.textContent.slice(5)),
674674
);
675-
requestDaysArray.push(requestedDays.slice(5));
675+
requestDaysArray.push(requestedDays);
676676
}
677-
const sortedRequestDaysArray = [...requestDaysArray].sort();
677+
678+
const sortedRequestDaysArray = requestDaysArray
679+
.slice()
680+
.sort((a, b) => a - b);
678681
expect(requestDaysArray).toEqual(sortedRequestDaysArray);
679682
});
680683

__tests__/task-requests/task-requestDetails.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ describe('Task request details page', () => {
6060
'[data-modal-start-date-value="proposed-start-date-value"]',
6161
(element) => element.textContent,
6262
);
63-
expect(proposedStartDateValue).toBe('30-10-2023');
63+
expect(proposedStartDateValue).toBe('Monday, 30 Oct 2023');
6464

6565
const proposedEndDateHeading = await page.$eval(
6666
'[data-modal-end-date-text="proposed-end-date-text"]',
@@ -72,7 +72,7 @@ describe('Task request details page', () => {
7272
'[data-modal-end-date-value="proposed-end-date-value"]',
7373
(element) => element.textContent,
7474
);
75-
expect(proposedEndDateValue).toBe('5-11-2023');
75+
expect(proposedEndDateValue).toBe('Sunday, 5 Nov 2023');
7676

7777
const descriptionTextHeading = await page.$eval(
7878
'[data-modal-description-text="proposed-description-text"]',
@@ -153,7 +153,7 @@ describe('Task request details page with markdown support in description', () =>
153153
'[data-modal-start-date-value="proposed-start-date-value"]',
154154
(element) => element.textContent,
155155
);
156-
expect(proposedStartDateValue).toBe('30-10-2023');
156+
expect(proposedStartDateValue).toBe('Monday, 30 Oct 2023');
157157

158158
const proposedEndDateHeading = await page.$eval(
159159
'[data-modal-end-date-text="proposed-end-date-text"]',
@@ -165,7 +165,7 @@ describe('Task request details page with markdown support in description', () =>
165165
'[data-modal-end-date-value="proposed-end-date-value"]',
166166
(element) => element.textContent,
167167
);
168-
expect(proposedEndDateValue).toBe('5-11-2023');
168+
expect(proposedEndDateValue).toBe('Sunday, 5 Nov 2023');
169169

170170
const descriptionTextHeading = await page.$eval(
171171
'[data-modal-description-text="proposed-description-text"]',

extension-requests/local-utils.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,12 +289,13 @@ function dateString(milliseconds) {
289289

290290
const fullDateString = (timestamp) => {
291291
const options = {
292-
weekday: 'short',
292+
weekday: 'long',
293293
year: 'numeric',
294-
month: 'long',
294+
month: 'short',
295295
day: 'numeric',
296296
hour: 'numeric',
297297
minute: 'numeric',
298+
timeZoneName: 'short',
298299
hour12: true,
299300
};
300301
return new Intl.DateTimeFormat('en-US', options).format(new Date(timestamp));

utils/time/index.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,18 @@ function getHumanReadableDate(timeStamp) {
44
}
55
const date = new Date(timeStamp);
66

7-
const year = date.getFullYear();
8-
const month = date.getMonth() + 1;
9-
const day = date.getDate();
7+
const options = {
8+
weekday: 'long',
9+
month: 'short',
10+
day: 'numeric',
11+
year: 'numeric',
12+
};
13+
const parts = date.toLocaleDateString('en-US', options).split(', ');
14+
15+
const [weekday, monthDay, year] = parts;
16+
const [month, day] = monthDay.split(' ');
17+
18+
const formattedDate = `${weekday}, ${day} ${month} ${year}`;
1019

11-
const formattedDate = `${day}-${month}-${year}`;
1220
return formattedDate;
1321
}

0 commit comments

Comments
 (0)