refactor: simplify isDev feature flag

Author: surnr

groups/script.js

@@ -27,11 +27,7 @@ const QUERY_PARAM_KEY = {
   DEV_FEATURE_FLAG: 'dev',
   GROUP_SEARCH: 'name',
 };
-
-const featureFlags = {
-  isMultipleGroupSharingEnabled:
-    getParamValueFromURL(QUERY_PARAM_KEY.DEV_FEATURE_FLAG) === 'true',
-};
+const isDev = getParamValueFromURL(QUERY_PARAM_KEY.DEV_FEATURE_FLAG) === 'true';
 
 const handler = {
   set: (obj, prop, value) => {
@@ -66,15 +62,13 @@ const handler = {
         });
         break;
       case 'search':
-        if (featureFlags.isMultipleGroupSharingEnabled) {
+        if (isDev) {
           setParamValueInURL(QUERY_PARAM_KEY.GROUP_SEARCH, value);
           dataStore.filteredGroupsIds = getDiscordGroupIdsFromSearch(
             Object.values(dataStore.groups),
             value,
           );
-        }
-        // Start: Remove this code if removing Feature Flag for isMultipleGroupSharingEnabled
-        else if (value === '') {
+        } else if (value === '') {
           if (dataStore.groups == null) break;
           dataStore.filteredGroupsIds = Object.values(dataStore.groups).map(
             (group) => group.id,
@@ -85,7 +79,6 @@ const handler = {
             .filter((group) => group.title.toLowerCase().includes(search))
             .map((group) => group.id);
         }
-        // End: Remove this code if removing Feature Flag for isMultipleGroupSharingEnabled
         obj[prop] = value;
         break;
       case 'isGroupCreationModalOpen':
@@ -129,9 +122,7 @@ const dataStore = new Proxy(
     userSelf: null,
     groups: null,
     filteredGroupsIds: null,
-    search: featureFlags.isMultipleGroupSharingEnabled
-      ? getParamValueFromURL(QUERY_PARAM_KEY.GROUP_SEARCH)
-      : '',
+    search: isDev ? getParamValueFromURL(QUERY_PARAM_KEY.GROUP_SEARCH) : '',
     discordId: null,
     isCreateGroupModalOpen: false,
   },
@@ -195,7 +186,7 @@ const afterAuthentication = async () => {
         };
         return acc;
       }, {});
-      if (featureFlags.isMultipleGroupSharingEnabled) {
+      if (isDev) {
         dataStore.filteredGroupsIds = getDiscordGroupIdsFromSearch(
           Object.values(dataStore.groups),
           dataStore.search,
@@ -218,9 +209,7 @@ const bindGroupCreationButton = () => {
 
 const bindSearchInput = () => {
   const searchInput = document.querySelector('.search__input');
-  if (featureFlags.isMultipleGroupSharingEnabled) {
-    searchInput.value = dataStore.search;
-  }
+  if (isDev) searchInput.value = dataStore.search;
   searchInput.addEventListener('input', (e) => {
     dataStore.search = e.target.value;
   });