Skip to content

Commit d990188

Browse files
authored
Merge pull request #747 from Real-Dev-Squad/develop
Dev to main sync
2 parents f51c8d2 + 30c18b1 commit d990188

File tree

20 files changed

+1409
-4
lines changed

20 files changed

+1409
-4
lines changed

__tests__/extension-requests/extension-requests.test.js

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,26 @@ describe('Tests the Extension Requests Screen', () => {
358358
},
359359
body: JSON.stringify(extensionRequestsListUserSearch),
360360
});
361+
} else if (
362+
url ===
363+
'https://api.realdevsquad.com/extension-requests?order=asc&size=1&q=status%3APENDING'
364+
) {
365+
interceptedRequest.respond({
366+
status: 200,
367+
contentType: 'application/json',
368+
headers: {
369+
'Access-Control-Allow-Origin': '*',
370+
'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE, OPTIONS',
371+
'Access-Control-Allow-Headers': 'Content-Type, Authorization',
372+
},
373+
body: JSON.stringify({
374+
message: 'Extension Requests returned successfully!',
375+
allExtensionRequests:
376+
extensionRequestsListPending?.allExtensionRequests.length > 0
377+
? [extensionRequestsListPending?.allExtensionRequests?.[1]]
378+
: [],
379+
}),
380+
});
361381
} else {
362382
interceptedRequest.continue();
363383
}
@@ -919,4 +939,44 @@ describe('Tests the Extension Requests Screen', () => {
919939
);
920940
expect(ascSortIconDisplayStyle).toBe('block');
921941
});
942+
943+
it('Should show empty message if all extension requests have been addressed', async () => {
944+
await page.goto(`${baseUrl}/?order=asc&size=1&q=status%3APENDING`);
945+
await page.waitForNetworkIdle();
946+
947+
extensionRequestsElement = await page.$('.extension-requests');
948+
let extensionCardsList = await page.$$('.extension-card');
949+
950+
if (extensionCardsList.length == 0) {
951+
const extensionRequestContainerText = await page.evaluate(
952+
(element) => element.innerText,
953+
extensionRequestsElement,
954+
);
955+
956+
expect(extensionRequestContainerText).toBe(
957+
'No extension requests to show!',
958+
);
959+
960+
return;
961+
}
962+
963+
for (const card of extensionCardsList) {
964+
let approveButton = await card.$('.approve-button');
965+
await approveButton.click();
966+
await page.waitForTimeout(1700);
967+
}
968+
969+
extensionRequestsElement = await page.$('.extension-requests');
970+
extensionCardsList = await extensionRequestsElement.$$('.extension-card');
971+
972+
const extensionRequestContainerText = await page.evaluate(
973+
(element) => element.innerText,
974+
extensionRequestsElement,
975+
);
976+
977+
expect(extensionCardsList.length).toBe(0);
978+
expect(extensionRequestContainerText).toBe(
979+
'No extension requests to show!',
980+
);
981+
});
922982
});

__tests__/home/home.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,16 @@ describe('Home Page', () => {
325325
expect(createActivityFeedButtonHref).toBe('/feed/index.html');
326326
});
327327

328+
it('should display the Requests anchor button', async () => {
329+
const requestsButton = await page.$('#requests-link');
330+
expect(requestsButton).toBeTruthy();
331+
const requestsButtonHref = await page.evaluate(
332+
(el) => el.getAttribute('href'),
333+
requestsButton,
334+
);
335+
expect(requestsButtonHref).toBe('/requests/index.html');
336+
});
337+
328338
it('should display the Discord Users anchor button', async () => {
329339
const discordUsersButton = await page.$('#discord-user-link');
330340
expect(discordUsersButton).toBeTruthy();

extension-requests/script.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -310,10 +310,10 @@ async function removeCard(element, elementClass) {
310310
.addEventListener('finish', () => {
311311
element.style.overflow = '';
312312
element.remove();
313+
if (extensionRequestsContainer.innerHTML === '') {
314+
addEmptyPageMessage(extensionRequestsContainer);
315+
}
313316
});
314-
if (extensionRequestsContainer.innerHTML === '') {
315-
addEmptyPageMessage(extensionRequestsContainer);
316-
}
317317
}
318318

319319
function addCheckbox(labelText, value, groupName) {

groups-dev/assets/avatar.svg

Lines changed: 6 additions & 0 deletions
Loading

groups-dev/assets/close.svg

Lines changed: 6 additions & 0 deletions
Loading

groups-dev/assets/github.png

13.3 KB
Loading

groups-dev/assets/info.svg

Lines changed: 12 additions & 0 deletions
Loading

groups-dev/assets/left-arrow.svg

Lines changed: 2 additions & 0 deletions
Loading

groups-dev/assets/person.svg

Lines changed: 7 additions & 0 deletions
Loading

groups-dev/assets/plus.svg

Lines changed: 14 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)