Skip to content

Commit 346bb15

Browse files
MBaeskenRealCLanger
authored andcommitted
SapMachine SAP#1982: Omit some cds archives in the delivery of SapMachine
1 parent 5d43f96 commit 346bb15

File tree

14 files changed

+48
-12
lines changed

14 files changed

+48
-12
lines changed

.github/workflows/build-alpine-linux.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ jobs:
8383
with:
8484
platform: alpine-linux-x64
8585

86+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
8687
- name: 'Configure'
8788
run: >
8889
bash configure
@@ -92,6 +93,7 @@ jobs:
9293
--with-boot-jdk=${{ steps.bootjdk.outputs.path }}
9394
--with-zlib=system
9495
--with-jmod-compress=zip-1
96+
--with-vendor-name="SAP SE"
9597
${{ inputs.extra-conf-options }} ${{ inputs.configure-arguments }} || (
9698
echo "Dumping config.log:" &&
9799
cat config.log &&

.github/workflows/build-cross-compile.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ jobs:
162162
sudo rm -rf sysroot/
163163
if: steps.create-sysroot.outcome != 'success' && steps.get-cached-sysroot.outputs.cache-hit != 'true'
164164

165+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
165166
- name: 'Configure'
166167
run: >
167168
bash configure
@@ -175,6 +176,7 @@ jobs:
175176
--openjdk-target=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-abi}}
176177
--with-sysroot=sysroot
177178
--with-jmod-compress=zip-1
179+
--with-vendor-name="SAP SE"
178180
CC=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-abi}}-gcc-${{ inputs.gcc-major-version }}
179181
CXX=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-abi}}-g++-${{ inputs.gcc-major-version }}
180182
${{ inputs.extra-conf-options }} ${{ inputs.configure-arguments }} || (

.github/workflows/build-linux.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ jobs:
116116
sudo apt-get install gcc-${{ inputs.gcc-major-version }}${{ inputs.gcc-package-suffix }} g++-${{ inputs.gcc-major-version }}${{ inputs.gcc-package-suffix }} libxrandr-dev${{ steps.arch.outputs.suffix }} libxtst-dev${{ steps.arch.outputs.suffix }} libcups2-dev${{ steps.arch.outputs.suffix }} libasound2-dev${{ steps.arch.outputs.suffix }} ${{ inputs.apt-extra-packages }}
117117
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${{ inputs.gcc-major-version }} 100 --slave /usr/bin/g++ g++ /usr/bin/g++-${{ inputs.gcc-major-version }}
118118
119+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
119120
- name: 'Configure'
120121
run: >
121122
bash configure
@@ -127,6 +128,7 @@ jobs:
127128
--with-gtest=${{ steps.gtest.outputs.path }}
128129
--with-zlib=system
129130
--with-jmod-compress=zip-1
131+
--with-vendor-name="SAP SE"
130132
${{ inputs.extra-conf-options }} ${{ inputs.configure-arguments }} || (
131133
echo "Dumping config.log:" &&
132134
cat config.log &&

.github/workflows/build-macos.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ jobs:
9595
# This will make GNU make available as 'make' and not only as 'gmake'
9696
echo '/usr/local/opt/make/libexec/gnubin' >> $GITHUB_PATH
9797
98+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
9899
- name: 'Configure'
99100
run: >
100101
bash configure
@@ -106,6 +107,7 @@ jobs:
106107
--with-gtest=${{ steps.gtest.outputs.path }}
107108
--with-zlib=system
108109
--with-jmod-compress=zip-1
110+
--with-vendor-name="SAP SE"
109111
${{ inputs.extra-conf-options }} ${{ inputs.configure-arguments }} || (
110112
echo "Dumping config.log:" &&
111113
cat config.log &&

.github/workflows/build-windows.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ jobs:
119119
--add Microsoft.VisualStudio.Component.VC.${{ inputs.msvc-toolset-version }}.${{ inputs.msvc-toolset-architecture }}
120120
if: steps.toolchain-check.outputs.toolchain-installed != 'true'
121121

122+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
122123
- name: 'Configure'
123124
run: >
124125
bash configure
@@ -130,6 +131,7 @@ jobs:
130131
--with-gtest=${{ steps.gtest.outputs.path }}
131132
--with-msvc-toolset-version=${{ inputs.msvc-toolset-version }}
132133
--with-jmod-compress=zip-1
134+
--with-vendor-name="SAP SE"
133135
${{ inputs.extra-conf-options }} ${{ inputs.configure-arguments }} || (
134136
echo "Dumping config.log:" &&
135137
cat config.log &&

make/Images.gmk

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,22 +193,23 @@ define CreateCDSArchive
193193
JRE_TARGETS += $$($1_$2_gen_cds_archive_jre)
194194
endef
195195

196+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
196197
ifeq ($(BUILD_CDS_ARCHIVE), true)
197-
$(foreach v, $(JVM_VARIANTS), \
198-
$(eval $(call CreateCDSArchive,$v,)) \
199-
)
198+
#$(foreach v, $(JVM_VARIANTS), \
199+
# $(eval $(call CreateCDSArchive,$v,)) \
200+
#)
200201

201202
ifeq ($(call isTargetCpuBits, 64), true)
202-
$(foreach v, $(JVM_VARIANTS), \
203-
$(eval $(call CreateCDSArchive,$v,_nocoops)) \
204-
)
203+
#$(foreach v, $(JVM_VARIANTS), \
204+
# $(eval $(call CreateCDSArchive,$v,_nocoops)) \
205+
#)
205206
ifeq ($(BUILD_CDS_ARCHIVE_COH), true)
206207
$(foreach v, $(JVM_VARIANTS), \
207208
$(eval $(call CreateCDSArchive,$v,_coh)) \
208209
)
209-
$(foreach v, $(JVM_VARIANTS), \
210-
$(eval $(call CreateCDSArchive,$v,_nocoops_coh)) \
211-
)
210+
# $(foreach v, $(JVM_VARIANTS), \
211+
# $(eval $(call CreateCDSArchive,$v,_nocoops_coh)) \
212+
# )
212213
endif
213214
endif
214215
endif

test/hotspot/jtreg/TEST.ROOT

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,10 @@ requires.extraPropDefns.vmOpts = \
5656
-XX:+WhiteBoxAPI \
5757
--add-exports java.base/jdk.internal.foreign=ALL-UNNAMED \
5858
--add-exports java.base/jdk.internal.misc=ALL-UNNAMED
59+
# SapMachine 2025-06-11: reduce number of cds/jsa archives
5960
requires.properties= \
6061
sun.arch.data.model \
62+
vm.vendor \
6163
vm.simpleArch \
6264
vm.bits \
6365
vm.flightRecorder \

test/hotspot/jtreg/runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,10 @@ private static void do_test(boolean CDS) throws IOException {
120120
}
121121

122122
public static void main(String[] args) throws Exception {
123-
System.out.println("Test with CDS");
124-
do_test(true);
123+
// SapMachine 2025-06-11: reduce number of cds/jsa archives
124+
// -Xshare:on can only be used for a configuration for which we have a jsa cds archive.
125+
//System.out.println("Test with CDS");
126+
//do_test(true);
125127
System.out.println("Test without CDS");
126128
do_test(false);
127129
}

test/hotspot/jtreg/runtime/ErrorHandling/AccessZeroNKlassHitsProtectionZone.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
/*
3939
* @test id=no_coh_cds
4040
* @summary Test that dereferencing a Klass that is the result of a decode(0) crashes accessing the nKlass guard zone
41+
* @comment SapMachine 2025-06-11: reduce number of cds/jsa archives, test would fail
42+
* @requires vm.vendor != "SAP SE"
4143
* @requires vm.cds & vm.bits == 64 & vm.debug == true & vm.flagless
4244
* @requires os.family != "aix"
4345
* @library /test/lib

test/hotspot/jtreg/runtime/cds/NonJVMVariantLocation.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
* @requires vm.flavor == "server"
3232
* @comment This test doesn't work on Windows because it depends on symlinks
3333
* @requires os.family != "windows"
34+
* @comment SapMachine 2025-06-11: reduce number of cds/jsa archives, test would fail
35+
* @requires vm.vendor != "SAP SE"
3436
* @library /test/lib appcds
3537
* @run driver NonJVMVariantLocation
3638
*/

0 commit comments

Comments
 (0)