fixed comments and tests

Author: Suvidh-kaushik

test/unit/middlewares/impersonationRequests.test.ts

@@ -31,7 +31,7 @@ describe("Impersonation Request Validators", function () {
     reason: "Testing purpose",
   };
 
-    const updateRequestBody: UpdateImpersonationRequestStatusBody = {
+  const updateRequestBody: UpdateImpersonationRequestStatusBody = {
     status: "APPROVED",
     message: "Testing",
   };
@@ -212,16 +212,14 @@ describe("Impersonation Request Validators", function () {
       expect(nextSpy.called).to.be.false;
     });
 
-    it("should invalidate if status field is not of correct type", async function () {
+      it("should invalidate if status field is not of correct type", async function () {
       req = {
         body: { ...updateRequestBody, status: "ACTIVE" },
       };
-      await updateImpersonationRequestValidator(
-        req as UpdateImpersonationRequest,
-        res as ImpersonationRequestResponse,
-        nextSpy
-      );
+      await updateImpersonationRequestValidator(req as UpdateImpersonationRequest,res as ImpersonationRequestResponse, nextSpy);
+      const errorMessageArg = res.boom.badRequest.firstCall.args[0];
       expect(res.boom.badRequest.calledOnce).to.be.true;
+      expect(errorMessageArg).to.include("status must be APPROVED or REJECTED");
       expect(nextSpy.called).to.be.false;
     });
   });

test/unit/models/impersonationRequests.test.ts

@@ -6,9 +6,10 @@ import { REQUEST_STATE, ERROR_WHILE_CREATING_REQUEST, ERROR_WHILE_UPDATING_REQUE
 import addUser from "../../utils/addUser";
 import userDataFixture from "../../fixtures/user/user";
 import sinon from "sinon";
-import { UpdateImpersonationRequestStatusBody } from "../../../types/impersonationRequest";
+import { UpdateImpersonationRequestStatusBody, UpdateImpersonationRequestDataResponse } from "../../../types/impersonationRequest";
 import { Timestamp } from "firebase-admin/firestore";
 import firestore from "../../../utils/firestore";
+
 const userData = userDataFixture();
 const logger = require("../../../utils/logger");
 
@@ -232,7 +233,7 @@ describe("models/impersonationRequests", () => {
       expect(updatedRequest.status).to.equal(REQUEST_STATE.REJECTED);
     });
 
-    it("should change the startedAt, endedAt and isImpersonationFinished fields on update", async () => {
+        it("should change the startedAt,endedAt and isImpersonationFinished fields on update", async () => {
       const updatedBody = {
         isImpersonationFinished: true,
         startedAt: Timestamp.fromDate(new Date(Date.now())),
@@ -242,16 +243,15 @@ describe("models/impersonationRequests", () => {
         id: impersonationRequest.id,
         updatePayload: updatedBody,
         lastModifiedBy: impersonationRequest.userId,
-      });
-      const result = await impersonationModel.getImpersonationRequestById(impersonationRequest.id);
-      expect(result.isImpersonationFinished).to.be.true;
-      expect(Number(result.startedAt)).to.be.greaterThan(0);
-      expect(Number(result.endedAt)).to.be.greaterThan(Number(result.startedAt));
+      }) as UpdateImpersonationRequestDataResponse;
+      expect(updatedRequest.isImpersonationFinished).to.be.true;
+      expect(Number(updatedRequest.startedAt)).to.be.greaterThan(0);
+      expect(Number(updatedRequest.endedAt)).to.be.greaterThan(Number(updatedRequest.startedAt));
     });
 
     it("should change updatedAt timestamp on update", async () => {
       const before = Number(impersonationRequest.updatedAt);
-      const updated = await impersonationModel.updateImpersonationRequest({
+      const updatedRequest = await impersonationModel.updateImpersonationRequesT({
         id: impersonationRequest.id,
         updatePayload: { status: "APPROVED" },
         lastModifiedBy: impersonationRequest.impersonatedUserId,
@@ -265,7 +265,6 @@ describe("models/impersonationRequests", () => {
       const error = new Error(ERROR_WHILE_UPDATING_REQUEST);
       const loggerStub = sinon.stub(logger, "error");
 
-      // Stub Firestore collection and doc chain
       const docUpdateStub = sinon.stub().rejects(error);
       const docStub = sinon.stub().returns({ update: docUpdateStub });
       const collectionStub = sinon.stub().returns({ doc: docStub });

test/unit/services/impersonationRequests.test.ts

@@ -261,7 +261,7 @@ describe("Tests Impersonation Requests Service", () => {
         await impersonationService.updateImpersonationRequestService(body);
         expect.fail("Should throw error");
       } catch (err) {
-        expect(loggerStub.calledWith(ERROR_WHILE_UPDATING_REQUEST, err)).to.true;
+        expect(loggerStub.calledWith(ERROR_WHILE_UPDATING_REQUEST, err)).to.be.true;
       }
     });
   });