Skip to content

Commit 1a89944

Browse files
fix: updated field names for consistency in OOO request handling
1 parent 301c5ea commit 1a89944

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

test/fixtures/oooRequest/oooRequest.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ export const createdOOORequest = {
2727
reason: validOooStatusRequests.reason,
2828
status: "PENDING",
2929
lastModifiedBy: null,
30-
requestedBy: "suraj-maity-1",
31-
userId: "jCqqOYCnm93mcmaYuSsQ",
30+
requestedBy: "jCqqOYCnm93mcmaYuSsQ",
3231
comment: null
3332
};
3433

@@ -87,15 +86,15 @@ export const createOooRequests = {
8786
from: Date.now() + 100000,
8887
until: Date.now() + 200000,
8988
message: "Out of office for personal reasons.",
90-
state: REQUEST_STATE.PENDING,
89+
status: REQUEST_STATE.PENDING,
9190
};
9291
export const createOooRequests2 = {
9392
requestedBy: "testUser2",
9493
type: "OOO",
9594
from: Date.now() + 100000,
9695
until: Date.now() + 200000,
9796
message: "Out of office for personal reasons.",
98-
state: REQUEST_STATE.PENDING,
97+
status: REQUEST_STATE.PENDING,
9998
};
10099

101100

test/integration/requests.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ describe("/requests OOO", function () {
188188
expect(res.body).to.not.have.property("data");
189189

190190
await requestsQuery.getRequestByKeyValues({
191-
userId: testUserId,
191+
requestedBy: testUserId,
192192
type: REQUEST_TYPE.OOO,
193193
status: REQUEST_STATE.PENDING
194194
}).then((request) => {

test/unit/services/oooRequest.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ describe("Test OOO Request Service", function() {
9595
expect(response).to.deep.include({
9696
...createdOOORequest,
9797
id: response.id,
98-
requestedBy:testUserName,
99-
userId: testUserId
98+
requestedBy: testUserId,
99+
100100
});
101101
});
102102

0 commit comments

Comments
 (0)