Revert "added one userauthorization middleware and test cases fixes"

This reverts commit 7dcd885.

Author: vikasosmium

controllers/stocks.js

@@ -48,31 +48,6 @@ const getSelfStocks = async (req, res) => {
   try {
     const { id: userId } = req.userData;
     const userStocks = await stocks.fetchUserStocks(userId);
-
-    res.set(
-      "X-Deprecation-Warning",
-      "WARNING: This endpoint is being deprecated and will be removed in the future. Please use `/stocks/:userId` route to get the user stocks details."
-    );
-    return res.json({
-      message: userStocks.length > 0 ? "User stocks returned successfully!" : "No stocks found",
-      userStocks,
-    });
-  } catch (err) {
-    logger.error(`Error while getting user stocks ${err}`);
-    return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
-  }
-};
-
-/**
- * Fetches all the stocks of the authenticated user
- *
- * @param req {Object} - Express request object
- * @param res {Object} - Express response object
- */
-const getUserStocks = async (req, res) => {
-  try {
-    const userStocks = await stocks.fetchUserStocks(req.params.userId);
-
     return res.json({
       message: userStocks.length > 0 ? "User stocks returned successfully!" : "No stocks found",
       userStocks,

middlewares/userAuthorization.ts

@@ -5,12 +5,9 @@ const authorizeRoles = require("../middlewares/authorizeRoles");
 const { addNewStock, fetchStocks, getSelfStocks } = require("../controllers/stocks");
 const { createStock } = require("../middlewares/validators/stocks");
 const { SUPERUSER } = require("../constants/roles");
-const { devFlagMiddleware } = require("../middlewares/devFlag");
-const { userAuthorization } = require("../middlewares/userAuthorization");
 
 router.get("/", fetchStocks);
 router.post("/", authenticate, authorizeRoles([SUPERUSER]), createStock, addNewStock);
-router.get("/user/self", authenticate, getSelfStocks); // this route will soon be deprecated, please use `/stocks/:userId` route.
-router.get("/:userId", devFlagMiddleware, authenticate, userAuthorization, getUserStocks);
+router.get("/user/self", authenticate, getSelfStocks);
 
 module.exports = router;