used constants for 403 error

Author: Suvidh-kaushik

controllers/impersonationRequests.ts

@@ -199,7 +199,7 @@ export const impersonationController = async (
   req: ImpersonationSessionRequest,
   res: ImpersonationRequestResponse,
   next: NextFunction
-): Promise<ImpersonationRequestResponse> => {
+): Promise<ImpersonationRequestResponse | void> => {
   const { action } = req.query;
   const requestId = req.params.id;
   const userId = req.userData?.id;
@@ -226,6 +226,6 @@ export const impersonationController = async (
     });
   } catch (error) {
     logger.error(`Failed to process impersonation ${action} for requestId=${requestId}, userId=${userId}`, error);
-    next(error);
+    return next(error);
   }
 };

services/impersonationRequests.ts

@@ -104,7 +104,7 @@ export const updateImpersonationRequestService = async (
     }
 
     if (request.impersonatedUserId !== body.lastModifiedBy || request.status !== REQUEST_STATE.PENDING) {
-      throw new Forbidden("You are not allowed for this Operation at the moment");
+      throw new Forbidden(OPERATION_NOT_ALLOWED);
     }
 
     const updatedRequest = await updateImpersonationRequest(body) as UpdateImpersonationStatusModelResponse;

test/integration/impersonationRequests.test.ts

@@ -19,7 +19,8 @@ import {
   REQUEST_DOES_NOT_EXIST,
   REQUEST_REJECTED_SUCCESSFULLY,
   REQUEST_STATE,
-  UNAUTHORIZED_TO_UPDATE_REQUEST
+  UNAUTHORIZED_TO_UPDATE_REQUEST,
+  OPERATION_NOT_ALLOWED
  } from "../../constants/requests";
 import { impersonationRequestsBodyData } from "../fixtures/impersonation-requests/impersonationRequests";
 
@@ -238,7 +239,7 @@ describe("Impersonation Requests", () => {
           if (err) return done(err);
           expect(res).to.have.status(403);
           expect(res.body.error).to.equal("Forbidden");
-          expect(res.body.message).to.equal("You are not allowed for this Operation at the moment");
+          expect(res.body.message).to.equal(OPERATION_NOT_ALLOWED);
           done();
         });
     });
@@ -253,7 +254,7 @@ describe("Impersonation Requests", () => {
           if (err) return done(err);
           expect(res).to.have.status(403);
           expect(res.body.error).to.equal("Forbidden");
-          expect(res.body.message).to.equal("You are not allowed for this Operation at the moment");
+          expect(res.body.message).to.equal(OPERATION_NOT_ALLOWED);
           done();
         });
     });
@@ -736,7 +737,7 @@ describe("Impersonation Requests", () => {
           if (err) return done(err);
           expect(res).to.have.status(403);
           expect(res.body.error).to.equal("Forbidden");
-          expect(res.body.message).to.equal("You are not allowed for this Operation at the moment");
+          expect(res.body.message).to.equal(OPERATION_NOT_ALLOWED);
           done();
         });
     });
@@ -751,7 +752,7 @@ describe("Impersonation Requests", () => {
           if (err) return done(err);
           expect(res).to.have.status(403);
           expect(res.body.error).to.equal("Forbidden");
-          expect(res.body.message).to.equal("You are not allowed for this Operation at the moment");
+          expect(res.body.message).to.equal(OPERATION_NOT_ALLOWED);
           done();
         });
     });
@@ -766,7 +767,7 @@ describe("Impersonation Requests", () => {
           if (err) return done(err);
           expect(res).to.have.status(403);
           expect(res.body.error).to.equal("Forbidden");
-          expect(res.body.message).to.equal("You are not allowed for this Operation at the moment");
+          expect(res.body.message).to.equal(OPERATION_NOT_ALLOWED);
           done();
         });
     });

test/unit/services/impersonationRequests.test.ts

@@ -9,7 +9,8 @@ import {
   REQUEST_REJECTED_SUCCESSFULLY,
   REQUEST_STATE,
   TASK_REQUEST_MESSAGES,
-  ERROR_WHILE_UPDATING_REQUEST
+  ERROR_WHILE_UPDATING_REQUEST,
+  OPERATION_NOT_ALLOWED
 } from "../../../constants/requests";
 import userDataFixture from "../../fixtures/user/user";
 import cleanDb from "../../utils/cleanDb";
@@ -144,7 +145,7 @@ describe("Tests Impersonation Requests Service", () => {
       } catch (err) {
         expect(err).to.not.be.undefined;
         expect(err.name).to.equal("ForbiddenError");
-        expect(err.message).to.equal("You are not allowed for this Operation at the moment");
+        expect(err.message).to.equal(OPERATION_NOT_ALLOWED);
       }
     });
 
@@ -167,7 +168,7 @@ describe("Tests Impersonation Requests Service", () => {
       } catch (err) {
         expect(err).to.not.be.undefined;
         expect(err.name).to.equal("ForbiddenError");
-        expect(err.message).to.equal("You are not allowed for this Operation at the moment");
+        expect(err.message).to.equal(OPERATION_NOT_ALLOWED);
       }
     });
 
@@ -201,7 +202,7 @@ describe("Tests Impersonation Requests Service", () => {
       } catch (err) {
         expect(err).to.not.be.undefined;
         expect(err.name).to.equal("ForbiddenError");
-        expect(err.message).to.equal("You are not allowed for this Operation at the moment");
+        expect(err.message).to.equal(OPERATION_NOT_ALLOWED);
       }
     });