Make firstname and lastname to lowercase (#2168)

* chore: make firstname and lastname to lowercase

* chore: remove type check

Author: vinit717

middlewares/validators/user.js

@@ -61,6 +61,14 @@ const updateUser = async (req, res, next) => {
 
   try {
     await schema.validateAsync(req.body);
+
+    if (req.body.first_name) {
+      req.body.first_name = req.body.first_name.toLowerCase();
+    }
+    if (req.body.last_name) {
+      req.body.last_name = req.body.last_name.toLowerCase();
+    }
+
     next();
   } catch (error) {
     logger.error(`Error validating updateUser payload : ${error}`);

test/unit/middlewares/user-validator.test.js

@@ -94,7 +94,11 @@ describe("Middleware | Validators | User", function () {
   describe("Create user validator for updateUser", function () {
     it("lets the request pass to next", async function () {
       const req = {
-        body: userData[1],
+        body: {
+          ...userData[1],
+          first_name: "Ankush",
+          last_name: "Dharkar",
+        },
       };
 
       const res = {};
@@ -310,6 +314,62 @@ describe("Middleware | Validators | User", function () {
 
       expect(nextSpy.calledOnce).to.be.equal(false);
     });
+
+    it("converts first_name to lowercase before passing to next", async function () {
+      const req = {
+        body: {
+          first_name: "Ankush",
+          last_name: "Dharkar",
+        },
+      };
+
+      const res = {};
+      const next = sinon.spy();
+      await updateUser(req, res, next);
+
+      expect(req.body.first_name).to.be.equal("ankush");
+      expect(req.body.last_name).to.be.equal("dharkar");
+      expect(next.calledOnce).to.be.equal(true);
+    });
+
+    it("converts last_name to lowercase before passing to next", async function () {
+      const req = {
+        body: {
+          first_name: "ANKUSH",
+          last_name: "DHARKAR",
+        },
+      };
+
+      const res = {};
+      const next = sinon.spy();
+      await updateUser(req, res, next);
+
+      expect(req.body.first_name).to.be.equal("ankush");
+      expect(req.body.last_name).to.be.equal("dharkar");
+      expect(next.calledOnce).to.be.equal(true);
+    });
+
+    it("stops the propagation of the next if first_name and last_name are not strings", async function () {
+      const req = {
+        body: {
+          first_name: 12345,
+          last_name: true,
+        },
+      };
+
+      const res = {
+        boom: {
+          badRequest: () => {},
+        },
+      };
+
+      const nextSpy = sinon.spy();
+      await updateUser(req, res, nextSpy).catch((err) => {
+        expect(err).to.be.an.instanceOf(Error);
+      });
+
+      expect(nextSpy.calledOnce).to.be.equal(false);
+    });
   });
 
   describe("Test the update Self Validator for disabled_roles property", function () {