Make enrichGroupDataWithMembershipInfo use the stubbed function

Author: Kavyashri217

models/discordactions.js

@@ -1,4 +1,5 @@
-const { generateDiscordProfileImageUrl } = require("../utils/discord-actions");
+const discordService = require("../services/discordService");
+const { addRoleToUser, removeRoleFromUser } = discordService;
 const firestore = require("../utils/firestore");
 const discordRoleModel = firestore.collection("discord-roles");
 const memberRoleModel = firestore.collection("member-group-roles");
@@ -14,13 +15,13 @@ const { ONE_DAY_IN_MS, SIMULTANEOUS_WORKER_CALLS } = require("../constants/users
 const userModel = firestore.collection("users");
 const photoVerificationModel = firestore.collection("photo-verification");
 const dataAccess = require("../services/dataAccessLayer");
-const { getDiscordMembers, addRoleToUser, removeRoleFromUser } = require("../services/discordService");
 const discordDeveloperRoleId = config.get("discordDeveloperRoleId");
 const discordMavenRoleId = config.get("discordMavenRoleId");
 const discordMissedUpdatesRoleId = config.get("discordMissedUpdatesRoleId");
 
 const userStatusModel = firestore.collection("usersStatus");
 const usersUtils = require("../utils/users");
+const { generateDiscordProfileImageUrl } = require("../utils/discord-actions");
 const { getUsersBasedOnFilter, fetchUser } = require("./users");
 const {
   convertDaysToMilliseconds,
@@ -329,7 +330,7 @@ const enrichGroupDataWithMembershipInfo = async (discordId, groups = []) => {
     });
 
     // Discord live role membership (used for memberCount)
-    const discordMembers = await getDiscordMembers();
+    const discordMembers = await discordService.getDiscordMembers();
     const liveRoleIdToCountMap = new Map();
 
     discordMembers.forEach((member) => {
@@ -411,7 +412,7 @@ const updateIdleUsersOnDiscord = async (dev) => {
     groupIdleRoleId = groupIdleRole.role.roleid;
     if (!groupIdleRole.roleExists) throw new Error("Idle Role does not exist");
     const { allUserStatus } = await getAllUserStatus({ state: userState.IDLE });
-    const discordUsers = await getDiscordMembers();
+    const discordUsers = await discordService.getDiscordMembers();
     const usersHavingIdleRole = [];
     discordUsers?.forEach((discordUser) => {
       const isDeveloper = discordUser.roles.includes(discordDeveloperRoleId);
@@ -636,7 +637,7 @@ const updateIdle7dUsersOnDiscord = async (dev) => {
     if (!groupIdle7dRole.roleExists) throw new Error("Idle Role does not exist");
 
     const { allUserStatus } = await getAllUserStatus({ state: userState.IDLE });
-    const discordUsers = await getDiscordMembers();
+    const discordUsers = await discordService.getDiscordMembers();
     const usersHavingIdle7dRole = [];
 
     discordUsers?.forEach((discordUser) => {
@@ -826,7 +827,7 @@ const updateUsersWith31DaysPlusOnboarding = async () => {
       allOnboardingUsers31DaysCompleted
     );
 
-    const discordMembers = await getDiscordMembers();
+    const discordMembers = await discordService.getDiscordMembers();
     const groupOnboardingRole = await getGroupRole("group-onboarding-31d+");
     const groupOnboardingRoleId = groupOnboardingRole.role.roleid;
     if (!groupOnboardingRole.roleExists) throw new Error("Role does not exist");
@@ -985,7 +986,7 @@ const getMissedProgressUpdatesUsers = async (options = {}) => {
     filteredByOoo: 0,
   };
   try {
-    const discordUsersPromise = getDiscordMembers();
+    const discordUsersPromise = discordService.getDiscordMembers();
     const missedUpdatesRoleId = discordMissedUpdatesRoleId;
 
     const normalizedExcludedWeekdays = new Set(

package.json

@@ -78,7 +78,7 @@
     "typescript": "5.3.3"
   },
   "engines": {
-    "node": "22.10.0"
+    "node": "^22.10.0"
   },
   "pre-commit": [
     "lint"

test/unit/services/discordService.test.js

@@ -16,6 +16,10 @@ const discordMembersArray = require("../../fixtures/discordResponse/discord-resp
 // const { func } = require("joi");
 let fetchStub;
 describe("Discord services", function () {
+  before(function () {
+    process.env.DISCORD_BASE_URL = "http://localhost:8080";
+  });
+
   describe("setInDiscordFalseScript", function () {
     beforeEach(async function () {
       const addUsersPromises = [];